Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdcm: Selecting suggestion doesn't filled up correctly input field #9308

Closed
woshilapin opened this issue Oct 11, 2024 · 3 comments
Closed
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM postponed Postponed task due to other priorities or waiting for dependencies severity:minor Minor severity bug

Comments

@woshilapin
Copy link
Contributor

woshilapin commented Oct 11, 2024

Note

Trigrams will be displayed differently, the UI is being designed. It should prevent this misunderstanding.

What happened?

When I type a text searching for a intermediate Operational Point, I get some suggestions. In this case, typing "Le Pon" propose a suggestion "LPT Le Pontet". If I select it (with mouse or with keyboard), the input field is filled up with "Le Pontet", not what I selected which is "LPT Le Pontet". If I click again on the on the right of the input field, and click again on the suggestion (or even if I click on the side to close the suggestions' popup), the input field is not filled up with "LPT Le Pontet".

What did you expect to happen?

I expect the field to be filled up with what is shown and selected in the suggestion popup.

How can we reproduce it (as minimally and precisely as possible)?

Enregistrement.de.l.ecran.2024-10-11.112954.mp4

On which environments the bug occurs?

Recette (SNCF)

On which browser the bug occurs?

Firefox

OSRD version (top right corner Account button > Informations)

96c960e (editoast, core) but nothing shown for front

@woshilapin woshilapin added area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug labels Oct 11, 2024
@woshilapin
Copy link
Contributor Author

Might be related to #9296 🤷

@axrolld
Copy link
Contributor

axrolld commented Oct 15, 2024

IMO (agreed with @thibautsailly ) the trigram should not be displayed once the field is selected. It's here in the suggestions because it can be an input but it should remain after the selection. We could maybe make this clearer i think. But in that case the bug is actually the second part : clicking in then out of the combo box make the trigram visible.
I'm postponing this until we set this clear.

@axrolld axrolld added the postponed Postponed task due to other priorities or waiting for dependencies label Oct 15, 2024
@axrolld
Copy link
Contributor

axrolld commented Oct 29, 2024

Expected behavior gathered in this bug. I'm closing this one if that's ok for you @woshilapin .

@axrolld axrolld closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM postponed Postponed task due to other priorities or waiting for dependencies severity:minor Minor severity bug
Projects
None yet
Development

No branches or pull requests

2 participants