Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: health check should be KO if invalid infra or non-existing (404 from editoast) #9388

Closed
bougue-pe opened this issue Oct 18, 2024 · 0 comments · Fixed by #9439
Closed
Assignees
Labels
area:core Work on Core Service area:osrdyne kind:architecture Software architecture work kind:bug Something isn't working kind:technical-enhancement severity:critical Critical severity bug

Comments

@bougue-pe
Copy link
Contributor

bougue-pe commented Oct 18, 2024

What happened?

Core stays "healthy" no matter the outcome of infra loading.
(no health endpoint exists)

This leads to some cases where a timeout from editoast locks core workers and the queue stays full

What did you expect to happen?

We could either add a liveness server or kill the process in case something is going unexpected when loading the infra.
What's expected is:

  • loading OK : obvious case
  • loading leads to an invalid infra : in this case, stay alive and reject any request on the same infra and same version
  • requesting an infra that doesn't exist anymore : stay alive and reject any request on that infra
  • any other case should lead to a retry of loading, then shutdown

How can we reproduce it (as minimally and precisely as possible)?

See above

On which environments the bug occurs?

Dev (SNCF)

On which browser the bug occurs?

Firefox

OSRD version (top right corner Account button > Informations)

dev

@bougue-pe bougue-pe added area:core Work on Core Service area:osrdyne kind:architecture Software architecture work kind:bug Something isn't working kind:technical-enhancement severity:critical Critical severity bug labels Oct 18, 2024
@bougue-pe bougue-pe self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service area:osrdyne kind:architecture Software architecture work kind:bug Something isn't working kind:technical-enhancement severity:critical Critical severity bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant