Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: improve conflict detection performances #9801

Closed
eckter opened this issue Nov 21, 2024 · 0 comments · Fixed by #9980
Closed

core: stdcm: improve conflict detection performances #9801

eckter opened this issue Nov 21, 2024 · 0 comments · Fixed by #9980
Assignees
Labels
area:core Work on Core Service kind:performance Reduction of computing time or memory use module:stdcm Short-Term DCM

Comments

@eckter
Copy link
Contributor

eckter commented Nov 21, 2024

In stdcm on long requests, we spend roughly 70% of the computation time identifying conflicts. And it's not even running the signaling simulation and similar complex things, it's really just listing and comparing requirements. Specifically, IncrementalConflictDetectorImpl.checkConflicts and IncrementalConflictDetectorImpl.analyzeConflicts take respectively 16% + 42% of the global execution time.

We could certainly do better.

Maybe instead of having a MutableList<SpacingZoneRequirement> for each zone, we could use something like a RangeSet, with time ranges where it's free / used.

@eckter eckter added area:core Work on Core Service kind:performance Reduction of computing time or memory use module:stdcm Short-Term DCM labels Nov 21, 2024
@eckter eckter self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service kind:performance Reduction of computing time or memory use module:stdcm Short-Term DCM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant