Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: stdcm: reduce grid margins from 35s to 15s #9946

Closed
eckter opened this issue Dec 4, 2024 · 0 comments · Fixed by #9984
Closed

front: stdcm: reduce grid margins from 35s to 15s #9946

eckter opened this issue Dec 4, 2024 · 0 comments · Fixed by #9984
Assignees
@SarahBellaha
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features module:stdcm Short-Term DCM

Comments

@eckter
Copy link
Contributor

eckter commented Dec 4, 2024 •
edited
Loading

Grid margins are margins we add before and after each occupations, they're also referenced as time_gap_before and time_gap_after in the code.

The front-end sets this value, there's no default value in the back. It can only be configured with debug mode.

Apparently it's not really useful, and we're looking for ways to improve the positive response rate. We should probably keep a few seconds to avoid simulation inaccuracies.

The default value should be updated in the debug mode elements, and when sending a request without debug mode on.

Image

EDIT: apparently we still need some margin, 15s seems like a better value
@eckter eckter added area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features module:stdcm Short-Term DCM labels Dec 4, 2024
@SarahBellaha SarahBellaha self-assigned this Dec 5, 2024
@SarahBellaha SarahBellaha linked a pull request Dec 5, 2024 that will close this issue
STDCM: linked path search adjustments #9953
Merged
@SarahBellaha SarahBellaha mentioned this issue Dec 5, 2024
Merged
@eckter eckter changed the title front: stdcm: reduce grid margins from 35s to 5s front: stdcm: reduce grid margins from 35s to 15s Dec 6, 2024
@SarahBellaha SarahBellaha mentioned this issue Dec 9, 2024
Merged
@SarahBellaha SarahBellaha removed a link to a pull request Dec 9, 2024
STDCM: linked path search adjustments #9953
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SarahBellaha SarahBellaha

Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features module:stdcm Short-Term DCM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

front: lmr: reduce grid margins from 35s to 15s OpenRailAssociation/osrd
2 participants
@eckter @SarahBellaha