front: match PathStep and SuggestedOP with pathStepId #10006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/match-by-path-step-id
branch
2 times, most recently
from
b7e3110 to
88ef272
Compare
emersion
force-pushed
the
emr/match-by-path-step-id
branch
6 times, most recently
from
3a4141b to
a0d75cf
Compare
|
Fyi : #10334 (comment) |
emersion
force-pushed
the
emr/match-by-path-step-id
branch
from
a0d75cf to
87277f4
Compare
Various spots need to check whether a SuggestedOP has a matching PathStep. Ensure the pathStepId field is always set when appropriate. Signed-off-by: Simon Ser <[email protected]>
Tests need to be adjusted to populate this field. Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
These have all been replaced with pathStepId checks. Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
Everybody uses pathStepId now. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/match-by-path-step-id
branch
from
87277f4 to
8e666be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last episode: #9967
Matching via uic/trigram/ch/etc is unreliable because:
path.
Moreover, we had multiple variants of the matching with slight
differences. Some of the matching logic got adjusted to account
for specific bugs, while others were left alone.
Each path step can be identified with a unique ID stored in
PathStep.id. Use that instead.
(The refactoring has been split into small digestible commits to ease bisecting and make it more obvious why type and test adjustments are necessary.)