Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: lmr reset prefilled values changed by the user #10490

Closed
wants to merge 1 commit into from

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Jan 22, 2025

fix #10270
When the user modifies or enters a value, it disables the prefill for mass, length, and max speed. This PR re-enables the prefill if the user removes the value.

@Wadjetz Wadjetz self-assigned this Jan 22, 2025
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 22, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.86%. Comparing base (c014f83) to head (176cdc8).
Report is 16 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10490      +/-   ##
==========================================
+ Coverage   81.80%   81.86%   +0.06%     
==========================================
  Files        1073     1073              
  Lines      106601   107075     +474     
  Branches      731      767      +36     
==========================================
+ Hits        87209    87662     +453     
- Misses      19353    19374      +21     
  Partials       39       39              
Flag Coverage Δ
editoast 74.53% <ø> (+0.22%) ⬆️
front 89.34% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz changed the title front: lmr reset prefiled user's changed values front: lmr reset prefilled values changed by the user Jan 23, 2025
@Wadjetz Wadjetz marked this pull request as ready for review January 23, 2025 08:35
@Wadjetz Wadjetz requested a review from a team as a code owner January 23, 2025 08:35
@SharglutDev
Copy link
Contributor

I think this will conflict with this PR : #10447 @Akctarus

@Wadjetz Wadjetz closed this Jan 23, 2025
@Wadjetz Wadjetz reopened this Jan 23, 2025
@Wadjetz
Copy link
Member Author

Wadjetz commented Jan 23, 2025

Close this PR it already fixed by #10447

@Wadjetz Wadjetz closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: changing a convoy value prevents it from being autofilled for all future rolling stock change
3 participants