From 56eb6c2d7ab5d32794957e31d9d9b8cfae9f40ae Mon Sep 17 00:00:00 2001
From: Clara Ni <clara.ni@outlook.fr>
Date: Wed, 12 Feb 2025 10:25:20 +0100
Subject: [PATCH 1/4] front: make searchOperationalPoints independent of state

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
---
 .../Map/Search/useSearchOperationalPoint.tsx  | 135 +++++++++---------
 1 file changed, 67 insertions(+), 68 deletions(-)

diff --git a/front/src/common/Map/Search/useSearchOperationalPoint.tsx b/front/src/common/Map/Search/useSearchOperationalPoint.tsx
index 413d9edf79a..b4d1fb1014e 100644
--- a/front/src/common/Map/Search/useSearchOperationalPoint.tsx
+++ b/front/src/common/Map/Search/useSearchOperationalPoint.tsx
@@ -1,14 +1,10 @@
-import { useState, useEffect, useMemo } from 'react';
+import { useState, useEffect, useMemo, useCallback } from 'react';
 
 import { isEmpty } from 'lodash';
 import { useSelector } from 'react-redux';
 
 import DPY_TO_MAS_OPERATIONAL_POINTS from 'assets/operationStudies/DPYToMASOperationalPoints';
-import {
-  type SearchQuery,
-  type SearchResultItemOperationalPoint,
-  osrdEditoastApi,
-} from 'common/api/osrdEditoastApi';
+import { type SearchResultItemOperationalPoint, osrdEditoastApi } from 'common/api/osrdEditoastApi';
 import { useInfraID } from 'common/osrdContext';
 import { setFailure } from 'reducers/main';
 import { getIsSuperUser } from 'reducers/user/userSelectors';
@@ -44,69 +40,70 @@ export default function useSearchOperationalPoint({
   const debouncedSearchTerm = useDebounce(searchTerm, debounceDelay);
   const [postSearch] = osrdEditoastApi.endpoints.postSearch.useMutation();
 
-  const searchOperationalPointsByTrigram = async (
-    infraId: number,
-    dpyToMasOperationalpointsFilter: SearchQuery
-  ) => {
-    const shouldSearchByTrigram =
-      !Number.isInteger(+debouncedSearchTerm) && debouncedSearchTerm.length < 4;
-
-    if (!shouldSearchByTrigram) return [];
-
-    const payload = {
-      object: 'operationalpoint',
-      query: [
-        'and',
-        ['=i', ['trigram'], debouncedSearchTerm],
-        ['=', ['infra_id'], infraId],
-        dpyToMasOperationalpointsFilter,
-      ],
-    };
-    try {
-      const results = (await postSearch({
-        searchPayload: payload,
-        pageSize: 101,
-      }).unwrap()) as SearchResultItemOperationalPoint[];
-      return results;
-    } catch (error) {
-      setFailure(castErrorToFailure(error));
-      return [];
-    }
-  };
+  const searchOperationalPointsByTrigram = useCallback(
+    async (searchQuery: string) => {
+      const shouldSearchByTrigram = !Number.isInteger(+searchQuery) && searchQuery.length < 4;
+
+      if (!shouldSearchByTrigram || !infraID) return [];
+
+      const dpyToMasOperationalpointsFilter = isStdcm && !isSuperUser ? DPY_TO_MAS_FILTER : true;
+
+      const payload = {
+        object: 'operationalpoint',
+        query: [
+          'and',
+          ['=i', ['trigram'], searchQuery],
+          ['=', ['infra_id'], infraID],
+          dpyToMasOperationalpointsFilter,
+        ],
+      };
+      try {
+        const results = (await postSearch({
+          searchPayload: payload,
+          pageSize: 101,
+        }).unwrap()) as SearchResultItemOperationalPoint[];
+        return results;
+      } catch (error) {
+        setFailure(castErrorToFailure(error));
+        return [];
+      }
+    },
+    [infraID, isStdcm, isSuperUser]
+  );
 
-  const searchOperationalPoints = async () => {
-    if (infraID === undefined) return;
-
-    const dpyToMasOperationalpointsFilter = isStdcm && !isSuperUser ? DPY_TO_MAS_FILTER : true;
-
-    const trigramResults = await searchOperationalPointsByTrigram(
-      infraID,
-      dpyToMasOperationalpointsFilter
-    );
-
-    try {
-      const results = (await postSearch({
-        searchPayload: {
-          object: 'operationalpoint',
-          query: [
-            'and',
-            [
-              'or',
-              ['search', ['name'], debouncedSearchTerm],
-              ['like', ['to_string', ['uic']], `%${debouncedSearchTerm}%`],
+  const searchOperationalPoints = useCallback(
+    async (searchQuery: string) => {
+      if (infraID === undefined) return [];
+
+      const trigramResults = await searchOperationalPointsByTrigram(searchQuery);
+
+      const dpyToMasOperationalpointsFilter = isStdcm && !isSuperUser ? DPY_TO_MAS_FILTER : true;
+
+      try {
+        const results = (await postSearch({
+          searchPayload: {
+            object: 'operationalpoint',
+            query: [
+              'and',
+              [
+                'or',
+                ['search', ['name'], searchQuery],
+                ['like', ['to_string', ['uic']], `%${searchQuery}%`],
+              ],
+              ['=', ['infra_id'], infraID],
+              dpyToMasOperationalpointsFilter,
             ],
-            ['=', ['infra_id'], infraID],
-            dpyToMasOperationalpointsFilter,
-          ],
-        },
-        pageSize: 101,
-      }).unwrap()) as SearchResultItemOperationalPoint[];
-      setSearchResults([...trigramResults, ...results]);
-    } catch (error) {
-      setFailure(castErrorToFailure(error));
-      setSearchResults([]);
-    }
-  };
+          },
+          pageSize: 101,
+        }).unwrap()) as SearchResultItemOperationalPoint[];
+        return [...trigramResults, ...results];
+      } catch (error) {
+        setFailure(castErrorToFailure(error));
+        return [];
+      }
+    },
+    [infraID, isStdcm, isSuperUser]
+  );
 
   const sortOperationalPoints = (
     a: SearchResultItemOperationalPoint,
@@ -172,7 +169,9 @@ export default function useSearchOperationalPoint({
 
   useEffect(() => {
     if (debouncedSearchTerm) {
-      searchOperationalPoints();
+      searchOperationalPoints(debouncedSearchTerm).then((results) => {
+        setSearchResults(results);
+      });
     } else if (searchResults.length !== 0) {
       setSearchResults([]);
     }

From ec495e9ed549a67769ef174b68087802b47c19c3 Mon Sep 17 00:00:00 2001
From: Clara Ni <clara.ni@outlook.fr>
Date: Wed, 12 Feb 2025 10:35:15 +0100
Subject: [PATCH 2/4] front: remove sortedSearchResults in
 useSearchOperationalPoint

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
---
 .../StdcmForm/StdcmOperationalPoint.tsx       |   7 +-
 .../Map/Search/MapSearchOperationalPoint.tsx  |  12 +-
 .../Map/Search/useSearchOperationalPoint.tsx  | 107 +++++++++---------
 3 files changed, 60 insertions(+), 66 deletions(-)

diff --git a/front/src/applications/stdcm/components/StdcmForm/StdcmOperationalPoint.tsx b/front/src/applications/stdcm/components/StdcmForm/StdcmOperationalPoint.tsx
index 723f2a46472..50c47785e4c 100644
--- a/front/src/applications/stdcm/components/StdcmForm/StdcmOperationalPoint.tsx
+++ b/front/src/applications/stdcm/components/StdcmForm/StdcmOperationalPoint.tsx
@@ -41,12 +41,7 @@ const StdcmOperationalPoint = ({ location, pathStepId, disabled }: StdcmOperatio
   const { t } = useTranslation('stdcm');
   const dispatch = useAppDispatch();
 
-  const {
-    searchTerm,
-    setSearchTerm,
-    sortedSearchResults: searchResults,
-    setSearchResults,
-  } = useSearchOperationalPoint({
+  const { searchTerm, setSearchTerm, searchResults, setSearchResults } = useSearchOperationalPoint({
     initialSearchTerm: location?.name,
     initialChCodeFilter: location?.secondary_code,
     isStdcm: true,
diff --git a/front/src/common/Map/Search/MapSearchOperationalPoint.tsx b/front/src/common/Map/Search/MapSearchOperationalPoint.tsx
index 7151b21a3cb..772bfab2047 100644
--- a/front/src/common/Map/Search/MapSearchOperationalPoint.tsx
+++ b/front/src/common/Map/Search/MapSearchOperationalPoint.tsx
@@ -28,7 +28,7 @@ const MapSearchOperationalPoint = ({
   const {
     searchTerm,
     chCodeFilter,
-    sortedSearchResults,
+    searchResults,
     filteredAndSortedSearchResults,
     mainOperationalPointsOnly,
     setSearchTerm,
@@ -57,7 +57,7 @@ const MapSearchOperationalPoint = ({
     switch (event.key) {
       case 'ArrowUp':
         setSelectedResultIndex((prevIndex) => {
-          const newIndex = prevIndex > 0 ? prevIndex - 1 : sortedSearchResults.length - 1;
+          const newIndex = prevIndex > 0 ? prevIndex - 1 : searchResults.length - 1;
           const element = document.getElementById(`result-${newIndex}`);
           if (element) {
             element.scrollIntoView({ block: 'nearest', inline: 'nearest' });
@@ -67,7 +67,7 @@ const MapSearchOperationalPoint = ({
         break;
       case 'ArrowDown':
         setSelectedResultIndex((prevIndex) => {
-          const newIndex = prevIndex < sortedSearchResults.length - 1 ? prevIndex + 1 : 0;
+          const newIndex = prevIndex < searchResults.length - 1 ? prevIndex + 1 : 0;
           const element = document.getElementById(`result-${newIndex}`);
           if (element) {
             element.scrollIntoView({ block: 'nearest', inline: 'nearest' });
@@ -133,15 +133,15 @@ const MapSearchOperationalPoint = ({
         </span>
       </div>
       <h2 className="text-center mt-3">
-        {sortedSearchResults.length > 100
+        {searchResults.length > 100
           ? t('resultsCountTooMuch')
           : t('resultsCount', {
               count: filteredAndSortedSearchResults.length,
             })}
       </h2>
       <div className="search-results">
-        {sortedSearchResults.length > 0 &&
-          sortedSearchResults.length <= 100 &&
+        {searchResults.length > 0 &&
+          searchResults.length <= 100 &&
           filteredAndSortedSearchResults.map((searchResult, index) => (
             <button
               id={`result-${index}`}
diff --git a/front/src/common/Map/Search/useSearchOperationalPoint.tsx b/front/src/common/Map/Search/useSearchOperationalPoint.tsx
index b4d1fb1014e..997551abaff 100644
--- a/front/src/common/Map/Search/useSearchOperationalPoint.tsx
+++ b/front/src/common/Map/Search/useSearchOperationalPoint.tsx
@@ -40,6 +40,49 @@ export default function useSearchOperationalPoint({
   const debouncedSearchTerm = useDebounce(searchTerm, debounceDelay);
   const [postSearch] = osrdEditoastApi.endpoints.postSearch.useMutation();
 
+  const sortOperationalPoints =
+    (searchQuery: string) =>
+    (a: SearchResultItemOperationalPoint, b: SearchResultItemOperationalPoint) => {
+      const upperCaseSearchTerm = searchQuery.toUpperCase();
+      const lowerCaseSearchTerm = searchQuery.toLowerCase();
+
+      // ops with trigram match first
+      if (a.trigram === upperCaseSearchTerm && b.trigram !== upperCaseSearchTerm) {
+        return -1;
+      }
+      if (b.trigram === upperCaseSearchTerm && a.trigram !== upperCaseSearchTerm) {
+        return 1;
+      }
+
+      // ops whose name starts by the searchTerm
+      const aStartsWithSearchTerm = a.name.toLowerCase().startsWith(lowerCaseSearchTerm);
+      const bStartsWithSearchTerm = b.name.toLowerCase().startsWith(lowerCaseSearchTerm);
+
+      if (aStartsWithSearchTerm && !bStartsWithSearchTerm) {
+        return -1;
+      }
+      if (!aStartsWithSearchTerm && bStartsWithSearchTerm) {
+        return 1;
+      }
+
+      // other matching ops alphabetically ordered
+      const nameComparison = a.name.localeCompare(b.name);
+      if (nameComparison !== 0) {
+        return nameComparison;
+      }
+
+      const chA = a.ch ?? '';
+      const chB = b.ch ?? '';
+
+      if (MAIN_OP_CH_CODES.includes(chA)) {
+        return -1;
+      }
+      if (MAIN_OP_CH_CODES.includes(chB)) {
+        return 1;
+      }
+      return chA.localeCompare(chB);
+    };
+
   const searchOperationalPointsByTrigram = useCallback(
     async (searchQuery: string) => {
       const shouldSearchByTrigram = !Number.isInteger(+searchQuery) && searchQuery.length < 4;
@@ -62,7 +105,9 @@ export default function useSearchOperationalPoint({
           searchPayload: payload,
           pageSize: 101,
         }).unwrap()) as SearchResultItemOperationalPoint[];
-        return results;
+        const sortedResults = [...results];
+        sortedResults.sort(sortOperationalPoints(searchQuery));
+        return sortedResults;
       } catch (error) {
         setFailure(castErrorToFailure(error));
         return [];
@@ -71,6 +116,7 @@ export default function useSearchOperationalPoint({
     [infraID, isStdcm, isSuperUser]
   );
 
+  /** Search for operational points by name or UIC code (primary code) */
   const searchOperationalPoints = useCallback(
     async (searchQuery: string) => {
       if (infraID === undefined) return [];
@@ -96,7 +142,10 @@ export default function useSearchOperationalPoint({
           },
           pageSize: 101,
         }).unwrap()) as SearchResultItemOperationalPoint[];
-        return [...trigramResults, ...results];
+
+        const allResults = [...trigramResults, ...results];
+        allResults.sort(sortOperationalPoints(searchQuery));
+        return allResults;
       } catch (error) {
         setFailure(castErrorToFailure(error));
         return [];
@@ -105,58 +154,9 @@ export default function useSearchOperationalPoint({
     [infraID, isStdcm, isSuperUser]
   );
 
-  const sortOperationalPoints = (
-    a: SearchResultItemOperationalPoint,
-    b: SearchResultItemOperationalPoint
-  ) => {
-    const upperCaseSearchTerm = debouncedSearchTerm.toUpperCase();
-    const lowerCaseSearchTerm = debouncedSearchTerm.toLowerCase();
-
-    // ops with trigram match first
-    if (a.trigram === upperCaseSearchTerm && b.trigram !== upperCaseSearchTerm) {
-      return -1;
-    }
-    if (b.trigram === upperCaseSearchTerm && a.trigram !== upperCaseSearchTerm) {
-      return 1;
-    }
-
-    // ops whose name starts by the searchTerm
-    const aStartsWithSearchTerm = a.name.toLowerCase().startsWith(lowerCaseSearchTerm);
-    const bStartsWithSearchTerm = b.name.toLowerCase().startsWith(lowerCaseSearchTerm);
-
-    if (aStartsWithSearchTerm && !bStartsWithSearchTerm) {
-      return -1;
-    }
-    if (!aStartsWithSearchTerm && bStartsWithSearchTerm) {
-      return 1;
-    }
-
-    // other matching ops alphabetically ordered
-    const nameComparison = a.name.localeCompare(b.name);
-    if (nameComparison !== 0) {
-      return nameComparison;
-    }
-
-    const chA = a.ch ?? '';
-    const chB = b.ch ?? '';
-
-    if (MAIN_OP_CH_CODES.includes(chA)) {
-      return -1;
-    }
-    if (MAIN_OP_CH_CODES.includes(chB)) {
-      return 1;
-    }
-    return chA.localeCompare(chB);
-  };
-
-  const sortedSearchResults = useMemo(
-    () => [...searchResults].sort(sortOperationalPoints),
-    [searchResults]
-  );
-
   const filteredAndSortedSearchResults = useMemo(
     () =>
-      sortedSearchResults.filter((result) => {
+      searchResults.filter((result) => {
         if (mainOperationalPointsOnly || (chCodeFilter && MAIN_OP_CH_CODES.includes(chCodeFilter)))
           return MAIN_OP_CH_CODES.includes(result.ch);
 
@@ -164,7 +164,7 @@ export default function useSearchOperationalPoint({
 
         return result.ch.toLocaleLowerCase().includes(chCodeFilter.trim().toLowerCase());
       }),
-    [sortedSearchResults, chCodeFilter, mainOperationalPointsOnly]
+    [searchResults, chCodeFilter, mainOperationalPointsOnly]
   );
 
   useEffect(() => {
@@ -184,7 +184,6 @@ export default function useSearchOperationalPoint({
   return {
     searchTerm,
     chCodeFilter,
-    sortedSearchResults,
     filteredAndSortedSearchResults,
     mainOperationalPointsOnly,
     searchResults,

From a6ec296b9ca8b23b9ac33c29511a7a22406c50f0 Mon Sep 17 00:00:00 2001
From: Clara Ni <clara.ni@outlook.fr>
Date: Wed, 12 Feb 2025 10:44:28 +0100
Subject: [PATCH 3/4] front: rename filteredAndSortedSearchRestuls ->
 searchResultsFilteredByCh

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
---
 .../Map/Search/MapSearchOperationalPoint.tsx  |  6 ++---
 .../Map/Search/useSearchOperationalPoint.tsx  | 23 ++++++++++---------
 2 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/front/src/common/Map/Search/MapSearchOperationalPoint.tsx b/front/src/common/Map/Search/MapSearchOperationalPoint.tsx
index 772bfab2047..1635700a5f8 100644
--- a/front/src/common/Map/Search/MapSearchOperationalPoint.tsx
+++ b/front/src/common/Map/Search/MapSearchOperationalPoint.tsx
@@ -29,7 +29,7 @@ const MapSearchOperationalPoint = ({
     searchTerm,
     chCodeFilter,
     searchResults,
-    filteredAndSortedSearchResults,
+    searchResultsFilteredByCh,
     mainOperationalPointsOnly,
     setSearchTerm,
     setChCodeFilter,
@@ -136,13 +136,13 @@ const MapSearchOperationalPoint = ({
         {searchResults.length > 100
           ? t('resultsCountTooMuch')
           : t('resultsCount', {
-              count: filteredAndSortedSearchResults.length,
+              count: searchResultsFilteredByCh.length,
             })}
       </h2>
       <div className="search-results">
         {searchResults.length > 0 &&
           searchResults.length <= 100 &&
-          filteredAndSortedSearchResults.map((searchResult, index) => (
+          searchResultsFilteredByCh.map((searchResult, index) => (
             <button
               id={`result-${index}`}
               type="button"
diff --git a/front/src/common/Map/Search/useSearchOperationalPoint.tsx b/front/src/common/Map/Search/useSearchOperationalPoint.tsx
index 997551abaff..632d4f39ff0 100644
--- a/front/src/common/Map/Search/useSearchOperationalPoint.tsx
+++ b/front/src/common/Map/Search/useSearchOperationalPoint.tsx
@@ -154,18 +154,19 @@ export default function useSearchOperationalPoint({
     [infraID, isStdcm, isSuperUser]
   );
 
-  const filteredAndSortedSearchResults = useMemo(
-    () =>
-      searchResults.filter((result) => {
-        if (mainOperationalPointsOnly || (chCodeFilter && MAIN_OP_CH_CODES.includes(chCodeFilter)))
-          return MAIN_OP_CH_CODES.includes(result.ch);
+  /** Filter operational points on secondary code (ch), if provided */
+  const searchResultsFilteredByCh = useMemo(() => {
+    if (
+      mainOperationalPointsOnly ||
+      (chCodeFilter !== undefined && MAIN_OP_CH_CODES.includes(chCodeFilter))
+    )
+      return searchResults.filter((result) => MAIN_OP_CH_CODES.includes(result.ch));
 
-        if (chCodeFilter === undefined) return true;
+    if (!chCodeFilter) return searchResults;
 
-        return result.ch.toLocaleLowerCase().includes(chCodeFilter.trim().toLowerCase());
-      }),
-    [searchResults, chCodeFilter, mainOperationalPointsOnly]
-  );
+    const chFilter = chCodeFilter.trim().toLowerCase();
+    return searchResults.filter((result) => result.ch.toLocaleLowerCase().includes(chFilter));
+  }, [searchResults, chCodeFilter, mainOperationalPointsOnly]);
 
   useEffect(() => {
     if (debouncedSearchTerm) {
@@ -184,7 +185,7 @@ export default function useSearchOperationalPoint({
   return {
     searchTerm,
     chCodeFilter,
-    filteredAndSortedSearchResults,
+    searchResultsFilteredByCh,
     mainOperationalPointsOnly,
     searchResults,
     searchOperationalPoints,

From 17c9ac782c7787d6e2c11acc330e46b7945696fe Mon Sep 17 00:00:00 2001
From: Clara Ni <clara.ni@outlook.fr>
Date: Wed, 12 Feb 2025 11:00:31 +0100
Subject: [PATCH 4/4] front: get all secondary codes when selecting an
 operational point in stdcm

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
---
 .../StdcmForm/StdcmOperationalPoint.tsx         | 17 +++++++++++++----
 .../Map/Search/useSearchOperationalPoint.tsx    |  1 +
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/front/src/applications/stdcm/components/StdcmForm/StdcmOperationalPoint.tsx b/front/src/applications/stdcm/components/StdcmForm/StdcmOperationalPoint.tsx
index 50c47785e4c..c1ac54016db 100644
--- a/front/src/applications/stdcm/components/StdcmForm/StdcmOperationalPoint.tsx
+++ b/front/src/applications/stdcm/components/StdcmForm/StdcmOperationalPoint.tsx
@@ -41,7 +41,13 @@ const StdcmOperationalPoint = ({ location, pathStepId, disabled }: StdcmOperatio
   const { t } = useTranslation('stdcm');
   const dispatch = useAppDispatch();
 
-  const { searchTerm, setSearchTerm, searchResults, setSearchResults } = useSearchOperationalPoint({
+  const {
+    searchTerm,
+    setSearchTerm,
+    searchResults,
+    setSearchResults,
+    searchOperationalPointsByTrigram,
+  } = useSearchOperationalPoint({
     initialSearchTerm: location?.name,
     initialChCodeFilter: location?.secondary_code,
     isStdcm: true,
@@ -98,14 +104,17 @@ const StdcmOperationalPoint = ({ location, pathStepId, disabled }: StdcmOperatio
     [searchResults]
   );
 
-  const handleCiSelect = (selectedSuggestion?: CIOption) => {
+  const handleCiSelect = async (selectedSuggestion?: CIOption) => {
+    dispatch(updateStdcmPathStep({ id: pathStepId, updates: { location: selectedSuggestion } }));
     if (selectedSuggestion) {
-      const newChSuggestions = extractChCodes(searchResults, selectedSuggestion);
+      const operationalPointParts = await searchOperationalPointsByTrigram(
+        selectedSuggestion.trigram
+      );
+      const newChSuggestions = extractChCodes(operationalPointParts, selectedSuggestion);
       setChSuggestions(newChSuggestions);
     } else {
       setChSuggestions([]);
     }
-    dispatch(updateStdcmPathStep({ id: pathStepId, updates: { location: selectedSuggestion } }));
   };
 
   const handleChSelect = (selectedChCode?: CHOption) => {
diff --git a/front/src/common/Map/Search/useSearchOperationalPoint.tsx b/front/src/common/Map/Search/useSearchOperationalPoint.tsx
index 632d4f39ff0..71dc075efda 100644
--- a/front/src/common/Map/Search/useSearchOperationalPoint.tsx
+++ b/front/src/common/Map/Search/useSearchOperationalPoint.tsx
@@ -189,6 +189,7 @@ export default function useSearchOperationalPoint({
     mainOperationalPointsOnly,
     searchResults,
     searchOperationalPoints,
+    searchOperationalPointsByTrigram,
     setSearchTerm,
     setChCodeFilter,
     setSearchResults,