-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: rewrite STDCM Allowances component#4918 #4938
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4938 +/- ##
============================================
+ Coverage 22.15% 22.30% +0.14%
Complexity 2287 2287
============================================
Files 852 847 -5
Lines 90454 89846 -608
Branches 2341 2336 -5
============================================
Hits 20037 20037
+ Misses 69128 68525 -603
+ Partials 1289 1284 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
857075d
to
1555ee9
Compare
fd27d5b
to
c1d5a2a
Compare
c1d5a2a
to
136e206
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ddb3e87
to
6a7adce
Compare
Yes @SharglutDev, the problem here is the value of the input is placed to the right. There is another PR which fix it by allowing to choose the position of the text in he input by passing a new prop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #4918