Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: rewrite STDCM Allowances component#4918 #4938

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented Aug 31, 2023

close #4918

@kmer2016 kmer2016 requested a review from a team as a code owner August 31, 2023 08:30
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #4938 (6a7adce) into dev (183d22b) will increase coverage by 0.14%.
Report is 3 commits behind head on dev.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #4938      +/-   ##
============================================
+ Coverage     22.15%   22.30%   +0.14%     
  Complexity     2287     2287              
============================================
  Files           852      847       -5     
  Lines         90454    89846     -608     
  Branches       2341     2336       -5     
============================================
  Hits          20037    20037              
+ Misses        69128    68525     -603     
+ Partials       1289     1284       -5     
Flag Coverage Δ
front 9.92% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...applications/stdcm/components/allowancesConsts.tsx 0.00% <ø> (ø)
front/src/applications/stdcm/formatStcmConf.ts 0.00% <0.00%> (ø)
.../src/applications/stdcm/views/OSRDCStdcmConfig.tsx 0.00% <0.00%> (ø)
.../modules/allowances/components/STDCMAllowances.tsx 0.00% <0.00%> (ø)

@kmer2016 kmer2016 force-pushed the cnh/new-allowances-component-for-stdcm branch from 857075d to 1555ee9 Compare August 31, 2023 15:37
@nicolaswurtz nicolaswurtz changed the title Rewrite STDCM Allowances component#4918 front: rewrite STDCM Allowances component#4918 Aug 31, 2023
@kmer2016 kmer2016 force-pushed the cnh/new-allowances-component-for-stdcm branch from fd27d5b to c1d5a2a Compare September 1, 2023 08:33
@kmer2016 kmer2016 force-pushed the cnh/new-allowances-component-for-stdcm branch from c1d5a2a to 136e206 Compare September 11, 2023 08:32
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested in local and seems to work (but I don't know stdcm very well to check everything).

It does'nt come from this PR, but there is something wrong with the "unit" props on the InputSNCF component.
image

@kmer2016 kmer2016 force-pushed the cnh/new-allowances-component-for-stdcm branch from ddb3e87 to 6a7adce Compare September 11, 2023 09:22
@kmer2016
Copy link
Contributor Author

kmer2016 commented Sep 11, 2023

Yes @SharglutDev, the problem here is the value of the input is placed to the right. There is another PR which fix it by allowing to choose the position of the text in he input by passing a new prop

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmer2016 kmer2016 added this pull request to the merge queue Sep 11, 2023
Merged via the queue into dev with commit 3e1a8da Sep 11, 2023
@kmer2016 kmer2016 deleted the cnh/new-allowances-component-for-stdcm branch September 11, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite STDCM Allowances component
4 participants