core: pathfinding: filter out routes without blocks #5515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eckter
force-pushed
the
ech/fix-broken-route-to-block
branch
from
b111c8e to
2414205
Compare
Codecov Report
@@ Coverage Diff @@
## dev #5515 +/- ##
=========================================
Coverage 18.80% 18.81%
- Complexity 2320 2321 +1
=========================================
Files 861 861
Lines 103592 103598 +6
Branches 2413 2414 +1
=========================================
+ Hits 19483 19487 +4
- Misses 82760 82761 +1
- Partials 1349 1350 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eckter
force-pushed
the
ech/fix-broken-route-to-block
branch
from
2414205 to
5263c45
Compare
multun
approved these changes
Oct 31, 2023
Khoyo
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5434
Fixes #3746
Fixes #5544
As explained in the comment: this should never happen, but poor signaling data may be the cause of routes that have no block. Filtering them out fixes the 500s caused by this case.