-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: quick fix for speed label #5531
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5531 +/- ##
============================================
+ Coverage 19.61% 19.62% +0.01%
Complexity 2332 2332
============================================
Files 907 908 +1
Lines 107693 107847 +154
Branches 2623 2626 +3
============================================
+ Hits 21124 21169 +45
- Misses 85013 85119 +106
- Partials 1556 1559 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Seems your changes are not taken into account when testing. You probably need to fix the conflict first. |
e5afd67
to
8830e7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8830e7c
to
2d6e172
Compare
@thibautsailly I have to succes implementing that |
Thx ! But why remove time ? time is as necessary as speed, could you let (and correct format if needed) time ? |
2d6e172
to
a8c8974
Compare
I still don't see @thibautsailly proposal |
#closes #5496
This is a quick fix which will remove badly formatted time and give a shadow to the speed to it will remained visible
Correct behavior correction need a rewrite of train display logic