Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor - be able to select a theme #5823

Merged
merged 1 commit into from
Nov 23, 2023
Merged

front: editor - be able to select a theme #5823

merged 1 commit into from
Nov 23, 2023

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Nov 23, 2023

Close #5806 & #5821

  • Adding the MapSettingsMapStyle component in the editor settings, and for that I changed a little bit the CSS.
  • sync labels of data and map layer in the editor with the one on the map.
  • adding missing color to some theme (see front: editor - be able to select a theme #5821)

@sim51 sim51 requested a review from a team as a code owner November 23, 2023 12:44
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (8ddf0c8) 19.61% compared to head (25ecf3b) 19.61%.
Report is 2 commits behind head on dev.

Files Patch % Lines
front/src/common/Map/Consts/colors.ts 0.00% 24 Missing ⚠️
...src/applications/editor/components/LayersModal.tsx 0.00% 2 Missing ⚠️
front/src/common/Map/Settings/MapSettings.tsx 0.00% 2 Missing ⚠️
...nt/src/common/Map/Settings/MapSettingsMapStyle.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5823      +/-   ##
============================================
- Coverage     19.61%   19.61%   -0.01%     
  Complexity     2332     2332              
============================================
  Files           907      907              
  Lines        107693   107712      +19     
  Branches       2623     2623              
============================================
  Hits          21124    21124              
- Misses        85013    85032      +19     
  Partials       1556     1556              
Flag Coverage Δ
front 8.59% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolaswurtz nicolaswurtz self-assigned this Nov 23, 2023
Close #5806 & #5821

- Adding the MapSettingsMapStyle component in the editor settings, and for
that I changed a little bit the CSS.
- sync labels of data and map layer in the editor with the one on the map.
- adding missing color to some theme (see #5821)
@sim51 sim51 enabled auto-merge November 23, 2023 14:37
@sim51 sim51 added this pull request to the merge queue Nov 23, 2023
Merged via the queue into dev with commit 4816d8b Nov 23, 2023
@sim51 sim51 deleted the bsi/issue-5821 branch November 23, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: Editor crash with theme other than the "normal" one
2 participants