front: fix overlap while searching by trigram with elipsis #6572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yohh
added
kind:bug
SharglutDev
reviewed
Feb 6, 2024
There was a problem hiding this comment.
Thank you for this fix, left one (optional, we probably need to discuss these use case in the next front meeting) suggestion.
The order of words in your commit is maybe a bit confusing, I think it would be more understandable like this :
front: fix overlap with ellipsis while searching by trigram
nicolaswurtz
approved these changes
Feb 6, 2024
SharglutDev
approved these changes
Feb 6, 2024
nicolaswurtz
deleted the
yoh/front-fix-long-text-overlap-while-search-by-trigram
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6570