Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: update display in rolling stock editor #8484

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

theocrsb
Copy link
Contributor

close #8370

@theocrsb theocrsb requested a review from a team as a code owner August 19, 2024 12:24
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.98%. Comparing base (c02e207) to head (a02136c).
Report is 1 commits behind head on dev.

Files Patch % Lines
...ents/RollingStockEditor/RollingStockEditorForm.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8484      +/-   ##
============================================
- Coverage     36.99%   36.98%   -0.01%     
  Complexity     2168     2168              
============================================
  Files          1271     1271              
  Lines        118008   118008              
  Branches       3174     3174              
============================================
- Hits          43652    43647       -5     
- Misses        72481    72486       +5     
  Partials       1875     1875              
Flag Coverage Δ
core 74.90% <ø> (ø)
editoast 66.33% <ø> (-0.02%) ⬇️
front 15.95% <0.00%> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested !

@kmer2016 kmer2016 enabled auto-merge August 19, 2024 13:46
Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and Tested ✅

@theocrsb theocrsb force-pushed the tce/front/bug-diplay-rolling-stock branch from bb2103a to a02136c Compare August 19, 2024 13:58
@kmer2016 kmer2016 added this pull request to the merge queue Aug 19, 2024
Merged via the queue into dev with commit 116f96b Aug 19, 2024
22 checks passed
@kmer2016 kmer2016 deleted the tce/front/bug-diplay-rolling-stock branch August 19, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small bugs on '*' for mandatory fields when creating a rolling stock
4 participants