Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: use pooling for amqp #9317

Merged
merged 1 commit into from
Oct 11, 2024
Merged

editoast: use pooling for amqp #9317

merged 1 commit into from
Oct 11, 2024

Conversation

ElysaSrc
Copy link
Member

@ElysaSrc ElysaSrc commented Oct 11, 2024

Closes #9318

@ElysaSrc ElysaSrc requested a review from a team as a code owner October 11, 2024 16:00
@ElysaSrc ElysaSrc requested a review from Khoyo October 11, 2024 16:00
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Oct 11, 2024
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not tested)

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 39.16%. Comparing base (665e2b6) to head (57d7303).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/core/mq_client.rs 0.00% 30 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9317      +/-   ##
============================================
- Coverage     39.17%   39.16%   -0.02%     
  Complexity     2245     2245              
============================================
  Files          1290     1290              
  Lines         97241    97265      +24     
  Branches       3280     3280              
============================================
- Hits          38093    38090       -3     
- Misses        57209    57236      +27     
  Partials       1939     1939              
Flag Coverage Δ
core 74.94% <ø> (ø)
editoast 72.46% <0.00%> (+0.03%) ⬆️
front 10.33% <ø> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
osrdyne 3.52% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@ElysaSrc ElysaSrc requested a review from a team as a code owner October 11, 2024 16:12
@ElysaSrc ElysaSrc requested a review from clarani October 11, 2024 16:12
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to resolve without addressing if in rush 🙏

Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this address the root issue (ie. probably channel leaks), but it might hide it enough for now

@ElysaSrc ElysaSrc force-pushed the ev/use-pooling branch 2 times, most recently from ff12eb1 to 3775b5b Compare October 11, 2024 17:44
@ElysaSrc
Copy link
Member Author

I don't believe this address the root issue (ie. probably channel leaks), but it might hide it enough for now

Added explicit closing of the channels.

@ElysaSrc ElysaSrc enabled auto-merge October 11, 2024 17:58
@ElysaSrc ElysaSrc added this pull request to the merge queue Oct 11, 2024
Merged via the queue into dev with commit e66e534 Oct 11, 2024
24 checks passed
@ElysaSrc ElysaSrc deleted the ev/use-pooling branch October 11, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: we reach the limit of channel per connexion on amqp client and crash subsequent requests
7 participants