-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: use pooling for amqp #9317
Conversation
1c0f664
to
01ccc2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (not tested)
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9317 +/- ##
============================================
- Coverage 39.17% 39.16% -0.02%
Complexity 2245 2245
============================================
Files 1290 1290
Lines 97241 97265 +24
Branches 3280 3280
============================================
- Hits 38093 38090 -3
- Misses 57209 57236 +27
Partials 1939 1939
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
01ccc2f
to
597491b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to resolve without addressing if in rush 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this address the root issue (ie. probably channel leaks), but it might hide it enough for now
ff12eb1
to
3775b5b
Compare
Added explicit closing of the channels. |
Signed-off-by: ElysaSrc <[email protected]>
3775b5b
to
57d7303
Compare
Closes #9318