Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: create type StdcmPathStep #9428

Merged
merged 2 commits into from
Oct 30, 2024
Merged

front: create type StdcmPathStep #9428

merged 2 commits into from
Oct 30, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 22, 2024

closes #9392

  • create a new type StdcmPathStep
  • add a new props stdcmPathSteps to the stdcmStore
  • create new actions: updateStdcmPathStep, addStdcmVia, removeStdcmVia
  • create new selectors: getStdcmPathSteps, getStdcmOrigin, getStdcmDestination
  • clean:
    • remove several actions: updateOriginArrival, updateDestinationArrival, updateOriginArrivalType, updateDestinationArrivalType, updateOriginTolerances, updateDestinationTolerances
    • clean some stdcm components

Will be followed by #9462

@clarani clarani requested a review from a team as a code owner October 22, 2024 15:23
@emersion emersion self-requested a review October 22, 2024 15:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 9.05350% with 221 lines in your changes missing coverage. Please review.

Project coverage is 39.65%. Comparing base (508ac32) to head (333b7dd).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...lications/stdcm/components/StdcmForm/StdcmVias.tsx 0.00% 52 Missing and 1 partial ⚠️
...ns/stdcm/components/StdcmForm/StdcmDestination.tsx 0.00% 34 Missing and 1 partial ⚠️
...cations/stdcm/components/StdcmForm/StdcmOrigin.tsx 0.00% 34 Missing and 1 partial ⚠️
...cations/stdcm/components/StdcmForm/StdcmConfig.tsx 0.00% 19 Missing ⚠️
front/src/reducers/osrdconf/stdcmConf/selectors.ts 0.00% 18 Missing and 1 partial ⚠️
...src/modules/pathfinding/helpers/getStepLocation.ts 20.00% 16 Missing ⚠️
front/src/reducers/osrdconf/stdcmConf/index.ts 56.66% 10 Missing and 3 partials ⚠️
...dcm/components/StdcmForm/StdcmOperationalPoint.tsx 0.00% 9 Missing ⚠️
...nt/src/applications/stdcm/utils/formatStdcmConf.ts 0.00% 9 Missing ⚠️
front/src/applications/stdcm/hooks/useStdcm.ts 0.00% 3 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9428      +/-   ##
============================================
+ Coverage     39.62%   39.65%   +0.02%     
  Complexity     2270     2270              
============================================
  Files          1300     1301       +1     
  Lines         99167    99061     -106     
  Branches       3283     3280       -3     
============================================
- Hits          39297    39280      -17     
+ Misses        57937    57851      -86     
+ Partials       1933     1930       -3     
Flag Coverage Δ
core 75.06% <ø> (ø)
editoast 73.28% <ø> (-0.04%) ⬇️
front 10.24% <9.05%> (+<0.01%) ⬆️
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/9392-refacto-stdcm-store branch 4 times, most recently from 1a52d2b to 5d1a191 Compare October 25, 2024 14:07
@clarani clarani force-pushed the cni/9392-refacto-stdcm-store branch from 10f4aee to ede9a59 Compare October 28, 2024 10:49
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to resolve the remaining two comments at your discretion.

Looks good, thanks a lot for this cleanup!

@clarani clarani force-pushed the cni/9392-refacto-stdcm-store branch from e7a66a9 to 333b7dd Compare October 30, 2024 08:14
@clarani clarani enabled auto-merge October 30, 2024 08:14
@clarani clarani added this pull request to the merge queue Oct 30, 2024
Merged via the queue into dev with commit d37839d Oct 30, 2024
24 checks passed
@clarani clarani deleted the cni/9392-refacto-stdcm-store branch October 30, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: create a simple StdcmPathStep type
3 participants