Skip to content

Commit 6063fe3

Browse files
committed
Fix isAtomicField method arg type
1 parent 248c2a1 commit 6063fe3

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

spotbugs/src/main/java/edu/umd/cs/findbugs/detect/AtomicOperationsCombinedDetector.java

+4-5
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
import edu.umd.cs.findbugs.ba.CFG;
5151
import edu.umd.cs.findbugs.ba.CFGBuilderException;
5252
import edu.umd.cs.findbugs.ba.ClassContext;
53-
import edu.umd.cs.findbugs.ba.ClassMember;
5453
import edu.umd.cs.findbugs.ba.DataflowAnalysisException;
5554
import edu.umd.cs.findbugs.ba.Location;
5655
import edu.umd.cs.findbugs.ba.OpcodeStackScanner;
@@ -152,12 +151,12 @@ private void collectFieldsForAtomicityCheck(ClassContext classContext, Method me
152151
}
153152
}
154153

155-
private static boolean isAtomicField(ClassMember classMember) {
156-
if (classMember == null) {
154+
private static boolean isAtomicField(XMethod xMethod) {
155+
if (xMethod == null) {
157156
return false;
158157
}
159-
return CollectionAnalysis.isSynchronizedCollection(classMember)
160-
|| (classMember.getClassName().startsWith("java.util.concurrent.atomic") && classMember.getSignature().endsWith(")V"));
158+
return CollectionAnalysis.isSynchronizedCollection(xMethod)
159+
|| (xMethod.getClassName().startsWith("java.util.concurrent.atomic") && xMethod.getSignature().endsWith(")V"));
161160
}
162161

163162
private void analyzeFieldsForAtomicityViolations(ClassContext classContext, Method method) throws CheckedAnalysisException {

0 commit comments

Comments
 (0)