Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting object numpy array? #175

Closed
dovahcrow opened this issue Feb 23, 2021 · 7 comments · Fixed by #216
Closed

Supporting object numpy array? #175

dovahcrow opened this issue Feb 23, 2021 · 7 comments · Fixed by #216
Labels
enhancement

Comments

@dovahcrow
Copy link

dovahcrow commented Feb 23, 2021 •
edited
Loading

Are there any reasons that we do not have Element implemented for PyObject?

As far as I can see, adding this line impl_num_element!(PyObject, Object, NPY_OBJECT); to dtype.rs should make it work.
@davidhewitt davidhewitt mentioned this issue Mar 10, 2021
Closed
@messense messense mentioned this issue Jul 11, 2021
Closed
@messense
Copy link
Member

See #143 (comment)

@kngwyu
Copy link
Member

kngwyu commented Jul 13, 2021

We don't have to close this, but I just don't know how it can work.

@kngwyu kngwyu reopened this Jul 13, 2021
@dovahcrow
Copy link
Author

We don't have to close this, but I just don't know how it can work.

Is it fixed through #195?

@kngwyu
Copy link
Member

kngwyu commented Jul 14, 2021

Is it fixed through

Not at all

@adamreichold
Copy link
Member

@kngwyu I am trying to reproduce the issues from #143 (comment), can I find the test code somewhere which triggered this?

@adamreichold
Copy link
Member

Is it the test added in this commit: b3f37a7

@kngwyu
Copy link
Member

kngwyu commented Nov 6, 2021

Yeah I think so

@adamreichold adamreichold mentioned this issue Nov 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Give PyArray<PyObject> another try.
Add support for object array PyO3/rust-numpy
4 participants
@dovahcrow @messense @adamreichold @kngwyu