Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nalgebra #263

Closed
sjbeskur opened this issue Jan 22, 2022 · 5 comments · Fixed by #347
Closed

Support for nalgebra #263

sjbeskur opened this issue Jan 22, 2022 · 5 comments · Fixed by #347

Comments

@sjbeskur
Copy link

Hi, this isn't really an issue but just a question as to whether your team might consider supporting nalgebra instead of (or alongside) ndarray in the future? Pybinds for C++ seems to have standardized on the popular Eigen library which is very robust where ndarray seems somewhat limited without other includes such as ndarray-linalg.

@adamreichold
Copy link
Member

Yes, while I would like this project to avoid discussing which array library is better or worse, we do plan to integrate with nalgebra. It is mainly a matter of finding the time to do the work.

@adamreichold adamreichold changed the title nalgebra vs ndarray Support for nalgebra Jan 22, 2022
@adamreichold
Copy link
Member

The current plan to get the largest possible ecosystem coverage while keeping a small dependency closure by default is to

  • make the current ndarray an optional dependency but enabled by default
  • make the current nalgebra an optional dependency
  • make an older version of ndarray an optional dependency with a separate feature flag
  • abstract out methods which need to available for multiple versions of ndarray or ndarray and nalgebra into traits
  • figure out what do for basics that we currently unconditionally borrow from ndarray like IxN

@sjbeskur
Copy link
Author

Many thanks for your prompt reply and for the roadmap... totally agree and definitely did not intend to stoke a debate.

@adamreichold
Copy link
Member

I did not mean to suggest closing the issue at all. Sorry if it came across like that. Will re-open as we do not have nalgebra squared away just yet...

@adamreichold
Copy link
Member

figure out what do for basics that we currently unconditionally borrow from ndarray like IxN

At the moment, remove our dependency on ndarray for these basics seems like an unreasonable amount of churn especially since ndarray is aligned much closer to what NumPy provides than nalgebra so having a mandatory dependency on ndarray but an optional dependency on nalgebra seems reasonable IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants