Merge pull request #196 from QwantResearch/fix-share-modal

Fix share favorite modal

Author: amatissart

package-lock.json

@@ -18,9 +18,10 @@
 .modal {
   position: absolute;
   border-radius: 3px;
+  overflow: auto;
 }
 
-.modal__geolocation {
+.modal__maps {
   width: 320px;
   padding: 30px 24px;
   background: url('../images/popup_top.svg') white no-repeat;
@@ -50,7 +51,7 @@
 
 .modal__subtitle {
   display: block;
-  font-size: 16px;
+  font-size: 13px;
   color: $secondary_text;
   margin-bottom: 16px;
 }

src/scss/includes/modals/index.scss

@@ -30,6 +30,10 @@
 .modal__masq_favorite__body {
   padding: 40px 40px;
   color: #5c6f84;
+
+  .modal__subtitle {
+    font-size: 16px;
+  }
 }
 
 .modal__masq_favorite__buttons {

src/scss/includes/modals/masq_favorite.scss

@@ -1,4 +1,4 @@
-<div class="modal__geolocation">
+<div class="modal__maps">
   <i class="icon-x modal__close" {{= click(this.close, this) }}></i>
   <h2 class="modal__title">{{= _('Geolocation not available.', 'geolocation') }}</h2>
   <span class="modal__subtitle">{{= _('You did not allow Qwant Maps to access your position.', 'geolocation') }}</span>

src/views/geolocation_denied_modal.dot

@@ -1,4 +1,4 @@
-<div class="modal__geolocation">
+<div class="modal__maps">
   <i class="icon-x modal__close" {{= click(this.close, this) }}></i>
   <h2 class="modal__title">{{= _('Geolocation with privacy!', 'geolocation') }}</h2>
   <span class="modal__subtitle">{{= _(`You need to know where you are? Please allow your application to access your location so that it can tell you. As stated in our {privacyPolicyLink} privacy policy {closeTag}, Qwant will not store your geolocation information. We don't want to know your whereabouts.`,

src/views/geolocation_modal.dot

@@ -1,26 +1,28 @@
-<i class="icon-x modal__close" {{= click(this.close, this) }}></i>
-<h2 class="modal__title">{{= _('Share link', 'share') }}</h2>
+<div class="modal__maps">
+  <i class="icon-x modal__close" {{= click(this.close, this) }}></i>
+  <h2 class="modal__title">{{= _('Share link', 'share') }}</h2>
 
-<div class="share_copy__input__container" {{= click(this.copy, this) }}>
-  <input id="share_url_data" value="{{= this.shareUrl }}" type="text"></input>
-  <div class="share_copy__container" id="share-copy-container">
-    <button class="share_copy__link">
-      <i class="icon-copy"></i>
-    </button>
-    <span class="share_copy__status">
-      <i class="icon-check share_copy__status__icon"></i>
-      {{= _('Copied !', 'share') }}
-    </span>
+  <div class="share_copy__input__container" {{= click(this.copy, this) }}>
+    <input id="share_url_data" value="{{= this.shareUrl }}" type="text"></input>
+    <div class="share_copy__container" id="share-copy-container">
+      <button class="share_copy__link">
+        <i class="icon-copy"></i>
+      </button>
+      <span class="share_copy__status">
+        <i class="icon-check share_copy__status__icon"></i>
+        {{= _('Copied !', 'share') }}
+      </span>
+    </div>
   </div>
-</div>
 
-<hr class="modal__hr">
-<i class="share__icons icon-facebook"></i>
-<a rel="noopener noreferrer" target="_blank" {{= this.openPopup() }} href="{{= this.facebookTemplate(this.shareUrl) }}" class="share__link">
-  {{= _('SHARE ON FACEBOOK', 'share') }}
-</a>
-<hr class="modal__hr">
-<i class="share__icons icon-twitter"></i>
-<a rel="noopener noreferrer" target="_blank" {{= this.openPopup() }} href="{{= this.twitterTemplate(this.shareUrl) }}" class="share__link">
-  {{= _('SHARE ON TWITTER', 'share') }}
-</a>
+  <hr class="modal__hr">
+  <i class="share__icons icon-facebook"></i>
+  <a rel="noopener noreferrer" target="_blank" {{= this.openPopup() }} href="{{= this.facebookTemplate(this.shareUrl) }}" class="share__link">
+    {{= _('SHARE ON FACEBOOK', 'share') }}
+  </a>
+  <hr class="modal__hr">
+  <i class="share__icons icon-twitter"></i>
+  <a rel="noopener noreferrer" target="_blank" {{= this.openPopup() }} href="{{= this.twitterTemplate(this.shareUrl) }}" class="share__link">
+    {{= _('SHARE ON TWITTER', 'share') }}
+  </a>
+</div>