use nexus context to generate nexus url #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +43,22 @@ def get_nexus_data_bag(node) | |||
| # | |||
| # @return [Chef::Mash] the credentials entry in the data bag item | |||
| def get_credentials(node) | |||
| get_nexus_data_bag(node)[:credentials] | |||
| if Chef::Config[:solo] | |||
|
Thanks for this! I am 👍 on this after the commented on code is removed. I'd like to see that code revisited in #48 so we can make this cookbook easier to use. |
|
i only wanted the first commit. it automatically added my second commit to the pull request. let me see if i can get it back to the state i submitted it. |
This reverts commit 156285a.
|
sorry about that. i only wanted the nexus context used when generating the url. i hope this will do. |
|
do you want me to clean up the pull request sans the chef-solo branching and resubmit? I reverted that commit and the current state is just the nexus context url generator. |
|
Nope, this looks good! Thanks! |
KAllan357
added a commit
that referenced
this pull request
Oct 30, 2013
use nexus context to generate nexus url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the nexus context is modified, the Chef::Nexus.nexus_available is failing due to the incorrectly generated endpoint.