feat: improve fahrbild with chevron animation, item alignment and bottom spacing (#94) #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grodien
requested review from
mghilardelli,
rawi-coding and
phirzel
as code owners
Grodien
changed the title
rawi-coding
requested changes
Feb 13, 2025
There was a problem hiding this comment.
Nice 👍 Ich habs relativ genau getestet und funktioniert in den meisten Fällen super. Hab nur zwei Animationsfehler festgestellt:
- Chevron ausserhalb von Tabelle in einzelnen Fällen beim manuellen Scrollen.
- Falsche Positionierung wahrscheinlich bei gleichzeitigem Pünktlichkeits-Event.
Ich kann sie dir live zeigen, das ist am einfachsten
das_client/lib/app/pages/journey/train_journey/widgets/table/config/chevron_animation_data.dart
Outdated
Show resolved
Hide resolved
das_client/lib/app/pages/journey/train_journey/widgets/table/config/chevron_animation_data.dart
Outdated
Show resolved
Hide resolved
rawi-coding
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.