Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AppComponent inputs/outputs #166

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

emersion
Copy link
Collaborator

@emersion emersion commented Jul 3, 2024

Description

This is the second part of #158, cleaned up and rebased.

Add inputs and outputs so that a custom element user can interact with NGE.

A netzgrafikDto input is introduced to get/set the data service's current DTO. A operation output is introduced to notify about DTO changes. The changes are described by a new Operation class.

The new additions have no impact on the existing behavior and can simply be ignored when unused (e.g. when NGE runs with its own backend).

cc @louisgreiner

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

@emersion emersion requested a review from aiAdrian as a code owner July 3, 2024 08:56
Add inputs and outputs so that a custom element user can interact
with NGE.

A netzgrafikDto input is introduced to get/set the data service's
current DTO. A operation output is introduced to notify about DTO
changes. The changes are described by a new Operation class.

Co-authored-by: Simon Ser <[email protected]>
@theocrsb theocrsb assigned theocrsb and unassigned theocrsb Jul 4, 2024
@louisgreiner louisgreiner self-requested a review July 4, 2024 10:03
@aiAdrian aiAdrian merged commit 9d2c6ee into SchweizerischeBundesbahnen:main Jul 4, 2024
5 checks passed
@aiAdrian
Copy link
Collaborator

aiAdrian commented Jul 4, 2024

Thank you! This feature allows the integration of the Netzgrafik editor into any related independent projects.

@emersion emersion deleted the standalone-ep-2 branch July 4, 2024 12:18
louisgreiner added a commit that referenced this pull request Jul 9, 2024
Add inputs and outputs so that a custom element user can interact
with NGE.

A netzgrafikDto input is introduced to get/set the data service's
current DTO. A operation output is introduced to notify about DTO
changes. The changes are described by a new Operation class.

Co-authored-by: Louis Greiner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants