Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Archived (read-only mode) variants are editable (even tho not persisted) #190

Closed
3 tasks done
louisgreiner opened this issue Jul 22, 2024 · 0 comments · Fixed by #257
Closed
3 tasks done
Assignees
Labels
bug Something isn't working

Comments

@louisgreiner
Copy link
Collaborator

louisgreiner commented Jul 22, 2024

Preflight Checklist

Bug type

Functionality

Which version are you using

2.5.0

Operating system

Ubuntu 22.04

Browser / Browser version

Mozilla 115

Input mode

Mouse/Keyboard

Additional settings

No response

What happened?

When read-only mode is enabled, a user can still "draw" trainrun sections, even tho it is not stored in the database. It might be confusing for a user to see new trainruns, and after reload notice that they are not persisted.

It would be better to fully disable the drawing tools.

image

The same bug can be reproduce when moving nodes

image

Steps to reproduce the issue

  1. Archive a variant
  2. Try draw a new trainrun (or edit an existing one)
  3. Notice edit
  4. Reload page
  5. Notice edit not persisted

Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants