Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doc: CREATE_NODES.md, spelling #264

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

SergeCroise
Copy link
Contributor

@SergeCroise SergeCroise commented Aug 24, 2024

  • semicolon-separate-value
  • comma separated filterable labels
  • alignment, aligned

Description

spelling issues

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

- semicolon-separate-value
- filterable
- alignment, aligned
@SergeCroise SergeCroise requested a review from aiAdrian as a code owner August 24, 2024 13:14
@SergeCroise SergeCroise marked this pull request as draft August 24, 2024 13:14
@SergeCroise SergeCroise marked this pull request as ready for review August 24, 2024 13:23
@@ -12,7 +12,7 @@ Whenever you need to create a new node. You should follow these steps:

[29-01-2024-005-create_nodes.webm](https://github.com/SchweizerischeBundesbahnen/netzgrafik-editor-frontend/assets/2674075/8ba6957c-de8e-467c-b7ae-c71b451d014e)

### Import nodes from a semicolon-seperate-value file (CSV)
### Import nodes from a semicolon-separate-value file (CSV)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Import nodes from a semicolon-separate-value file (CSV)
### Import nodes from a semicolon-separated-value file (CSV)

@@ -28,7 +28,7 @@ so that the layout comes directly from the import.
| | BP | Bahnhof | Kategorie | Region | Fahrgastwechselzeit_IPV | Fahrgastwechselzeit_A | Fahrgastwechselzeit_B | Fahrgastwechselzeit_C | Fahrgastwechselzeit_D | ZAZ | Umsteigezeit | Labels | X | Y | Erstellen |
|:----------------:|:--------------------------------------------:|:------------------------------------------------:|:--------------:|:-------------:|:--------------------------------------------------:|:--------------------------------------------------:|:--------------------------------------------------:|:--------------------------------------------------:|:--------------------------------------------------:|:-------------:|:--------------------------------:|:--------------------------------:|:-----------------:|:-------------------:|:---------------------------------------------------------------:|
| Datatype | string | string | string | nummeric | nummeric | nummeric | nummeric | nummeric | nummeric | nummeric | nummeric | nummeric | nummeric | nummeric | 'JA' or empty |
| Description | id | full name | category label | region number | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | no implemened | min. connectiontime - Default: 2 | comma separated filerable labels | vertical position | horizontal position | if 'JA' missing nodes gets created, otherwise just updated (ID) |
| Description | id | full name | category label | region number | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | no implemened | min. connectiontime - Default: 2 | comma separated filterable labels | vertical position | horizontal position | if 'JA' missing nodes gets created, otherwise just updated (ID) |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Description | id | full name | category label | region number | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | no implemened | min. connectiontime - Default: 2 | comma separated filterable labels | vertical position | horizontal position | if 'JA' missing nodes gets created, otherwise just updated (ID) |
| Description | id | full name | category label | region number | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | if <= 0 -> non stop, otherwise > default stop time | not implemented | min. connectiontime - Default: 2 | comma separated filterable labels | vertical position | horizontal position | if 'JA' missing nodes gets created, otherwise just updated (ID) |

Copy link
Collaborator

@aiAdrian aiAdrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aiAdrian aiAdrian merged commit 30cf1d7 into SchweizerischeBundesbahnen:main Aug 26, 2024
6 checks passed
@SergeCroise SergeCroise deleted the patch-6 branch September 18, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants