Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Technical - replace hard coded style with common browser css styling <sbb-icon-sidebar-container> #273

Merged

Conversation

aiAdrian
Copy link
Collaborator

@aiAdrian aiAdrian commented Aug 28, 2024

Description

Replaced hard coded styling with css one (much better)

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

@aiAdrian aiAdrian linked an issue Aug 28, 2024 that may be closed by this pull request
3 tasks
@aiAdrian aiAdrian changed the title refactoring -> replace hard coded style with common browser css styling fix: replace hard coded style with common browser css styling Aug 28, 2024
@aiAdrian aiAdrian changed the title fix: replace hard coded style with common browser css styling fix: Technical - replace hard coded style with common browser css styling <sbb-icon-sidebar-container> Aug 28, 2024
Copy link
Contributor

@chenkins chenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check changed value. Otherwise lgtm.

@aiAdrian aiAdrian merged commit b505d03 into main Aug 29, 2024
6 checks passed
@aiAdrian aiAdrian deleted the 272-bug-sbb-icon-sidebar-container-integration-issue-fix branch August 29, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: sbb-icon-sidebar-container integration issue fix
2 participants