Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Origin/Destination matrix #301

Merged

Conversation

shenriotpro
Copy link
Contributor

@shenriotpro shenriotpro commented Oct 1, 2024

Description

(I'll fix the commit message after reviews.)

This is the first useful version of this feature. There is still some room for optimization, but it seems quite fast so far (2s for the medium example). Note that some trainruns don't have any endNode on this example.

Issues

close #269

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

@shenriotpro shenriotpro changed the title WIP WIP O/D matrix Oct 1, 2024
@emersion emersion self-requested a review October 2, 2024 07:38
@shenriotpro shenriotpro changed the title WIP O/D matrix Implement O/D matrix Oct 7, 2024
@shenriotpro shenriotpro marked this pull request as ready for review October 7, 2024 12:34
@shenriotpro shenriotpro requested a review from aiAdrian as a code owner October 7, 2024 12:34
@shenriotpro
Copy link
Contributor Author

@louisgreiner @jacomyal

@shenriotpro shenriotpro changed the title Implement O/D matrix feat: Implement O/D matrix Oct 8, 2024
Copy link
Collaborator

@louisgreiner louisgreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the excellent documentation that makes this new feature easy to read. The code is also very cleaned

I just wonder if some variable names would not be better if they could be more explicit. I commented a few things about that, feel free to ignore if it adds too much noise.

Overall high quality code, it needs to be challenged by the users. Next step is implementing an interface and optimizing

PS: the test unit is very good 🥇

@aiAdrian aiAdrian changed the title feat: Implement O/D matrix feat: Implement Origin/Destination matrix Oct 10, 2024
Copy link
Collaborator

@aiAdrian aiAdrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work!

@aiAdrian aiAdrian merged commit 383c99d into SchweizerischeBundesbahnen:main Oct 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Implement a Pathfinding algorithm for Origin / Destination
3 participants