Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate originDestination connectionPenalty to netzgrafikDto #314

Merged
merged 2 commits into from
Oct 17, 2024
Merged

feat: migrate originDestination connectionPenalty to netzgrafikDto #314

merged 2 commits into from
Oct 17, 2024

Conversation

shenriotpro
Copy link
Contributor

@shenriotpro shenriotpro commented Oct 16, 2024 •
edited
Loading

Description

migrate originDestination connectionPenalty to netzgrafikDto

Issues

#199

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

@shenriotpro shenriotpro changed the title feat: migrate originDestination connectionPenalty to netzgrafixDto feat: migrate originDestination connectionPenalty to netzgrafikDto Oct 16, 2024
@shenriotpro shenriotpro marked this pull request as ready for review October 16, 2024 13:12
@shenriotpro shenriotpro requested a review from aiAdrian as a code owner October 16, 2024 13:12
aiAdrian
aiAdrian requested changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@aiAdrian aiAdrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. It might be worthwhile to have a few words written DATA_MODEL_JSON.md about the settings and the impact of the parameters set in analyticsSettings.

@aiAdrian aiAdrian self-requested a review October 16, 2024 16:09
@shenriotpro
Copy link
Contributor Author

Thanks for the changes. It might be worthwhile to have a few words written DATA_MODEL_JSON.md about the settings and the impact of the parameters set in analyticsSettings.

Thanks for the quick review. Did you have a look at the second commit? Is there something specific you would like me to add?

aiAdrian
aiAdrian approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@aiAdrian aiAdrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@aiAdrian aiAdrian merged commit ce3f90d into SchweizerischeBundesbahnen:main Oct 17, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiAdrian aiAdrian aiAdrian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenriotpro @aiAdrian