Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Simplified third-party JSON import (no port alignment/path precalculation required) #341

Conversation

aiAdrian
Copy link
Collaborator

@aiAdrian aiAdrian commented Nov 11, 2024

Description

The import of JSON from third-party providers has been simplified - or allowed. If no node has a port or if all ports are empty or no TrainrunSection has a path, then the import should be adjusted so that all nodes are created and then each train is inserted section by section. This makes the import (exchange) from 3rd party more easy.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

…d - or allowed. If no node has a port or if all ports are empty or no TrainrunSection has a path, then the import should be adjusted so that all nodes are created and then each train is inserted section by section. This makes the import (exchange) from 3rd party more easy.
@aiAdrian aiAdrian merged commit d7d1776 into main Nov 11, 2024
7 checks passed
@aiAdrian aiAdrian deleted the 340-feature-request-extension-of-import-function-and-automatic-port-alignment-detection branch November 11, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Extension of Import Function and Automatic Port Alignment Detection
1 participant