fix: warn users when having unsymmetric times #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
SergeCroise
reviewed
Nov 18, 2024
src/app/view/editor-tools-view-component/editor-tools-view.component.ts
Outdated
Show resolved
Hide resolved
SergeCroise
reviewed
Nov 18, 2024
… will have an <svg:title>....</svg:title> tag. This improves rendering performance.
…ponent.ts Thanks Co-authored-by: Serge Croisé <[email protected]>
…lity) for trainrun section validation
aiAdrian
commented
Nov 19, 2024
SergeCroise
reviewed
Nov 19, 2024
SergeCroise
reviewed
Nov 19, 2024
Co-authored-by: Serge Croisé <[email protected]>
louisgreiner
approved these changes
Nov 21, 2024
aiAdrian
deleted the
358-bug-if-symmetry-gets-broken-the-editor-has-to-warn-the-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add warning for unsymmetric times. Those times can be imported when importing Netzgrafik from 3rd parties
Previously, the system did not warn users about the presence of unsymmetric times. This commit adds functionality to detect and alert users when unsymmetric times exists.
2nd part of the fix is that the user will have a tooltip (svg:titel) show warning message when hovering over the element.
Issues
Checklist
documentation/