Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix trains going back in OD matrix #395

Merged
merged 4 commits into from
Jan 15, 2025
Merged

fix: fix trains going back in OD matrix #395

merged 4 commits into from
Jan 15, 2025

Conversation

shenriotpro
Copy link
Contributor

@shenriotpro shenriotpro commented Jan 2, 2025 •
edited
Loading

Description

See issue, no path change on the default netzgrafik https://schweizerischebundesbahnen.github.io/netzgrafik-editor-frontend/ but there is a performance impact (600 ms -> 800 ms on my example).

I'll rename and squash commits after review.

Issues

#326

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

@shenriotpro
Copy link
Contributor Author

fix #326

@shenriotpro shenriotpro changed the title WIP bug: fix trains going back in OD matrix bug: fix trains going back in OD matrix Jan 6, 2025
@shenriotpro shenriotpro changed the title bug: fix trains going back in OD matrix fix: fix trains going back in OD matrix Jan 6, 2025
@shenriotpro shenriotpro marked this pull request as ready for review January 6, 2025 11:56
@shenriotpro shenriotpro requested a review from aiAdrian as a code owner January 6, 2025 11:56
@shenriotpro shenriotpro requested a review from aiAdrian January 13, 2025 09:32
aiAdrian
aiAdrian approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@aiAdrian aiAdrian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can be merged.

@aiAdrian aiAdrian added enhancement New feature or request Origin-Destination-Matrix bug Something isn't working and removed enhancement New feature or request labels Jan 14, 2025
@aiAdrian aiAdrian merged commit 173986c into SchweizerischeBundesbahnen:main Jan 15, 2025
7 checks passed
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiAdrian aiAdrian aiAdrian approved these changes

Assignees

@shenriotpro shenriotpro

Labels
bug Something isn't working Origin-Destination-Matrix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenriotpro @aiAdrian