Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Trainrun dialog window - in graphic timetable (Streckengrafik) wrong node order #70

Open
3 tasks done
aiAdrian opened this issue Apr 8, 2024 · 0 comments
Open
3 tasks done
Labels
bug Something isn't working

Comments

@aiAdrian
Copy link
Collaborator

aiAdrian commented Apr 8, 2024

Preflight Checklist

Bug type

None

Which version are you using

2.5.0

What happened?

Describe in detail the issue you are having.
What did you expect to happen? What happened instead? What would you like to see changed?
Is the issue related to a specific component?

Dependant Issues

  • If a trainrun starts at a Node N and ends at same Node N and all sections have non-stops in-between (make non-sense, then the train runs without stopping - just a trip but non-comerical stops) - but then the locks can not correctly set!

Steps to reproduce the issue

Upload JSON
netzgrafik_issue_70.json

image

  1. Select REX
    image

  2. Open Graphic timetable (Streckengrafi)

image

  1. Click on 28' on the 2nd section (B1 - C1)
    image

** ERROR ** wrong order - should be B1 -> C1 instead of C1 -> B1

or Click on another trainrun - it behaves similar

image

The problem origins from the design/layout - The heuristic is wrong in the dialog window when using streckengrafik (graphic timetable). In the graphic timetable the node order left-right must be used, instead of the editor's layout order heuristic - but in the editor the dialog is correct !!:

image

Hint

It might be worth to refactor/rewrite most of the logic. Take attention, that some of the code is re-used in the perlenkette (pearls view!)

See also : #101

@aiAdrian aiAdrian added the bug Something isn't working label Apr 8, 2024
@aiAdrian aiAdrian changed the title [Bug]: Graphic timetable (Streckengrafi) wrong node order in trainrun dialog window [Bug]: Graphic timetable (Streckengrafik) wrong node order in trainrun dialog window Apr 8, 2024
@aiAdrian aiAdrian changed the title [Bug]: Graphic timetable (Streckengrafik) wrong node order in trainrun dialog window [Bug]: Trainrun dialog window - in graphic timetable (Streckengrafik) wrong node order and also in Netzgrafik-Editor Apr 25, 2024
@aiAdrian aiAdrian changed the title [Bug]: Trainrun dialog window - in graphic timetable (Streckengrafik) wrong node order and also in Netzgrafik-Editor [Bug]: Trainrun dialog window - in graphic timetable (Streckengrafik) wrong node order Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant