Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue I. + typo #72

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: issue I. + typo #72

merged 1 commit into from
Apr 9, 2024

Conversation

louisgreiner
Copy link
Collaborator

@louisgreiner louisgreiner commented Apr 9, 2024 •
edited
Loading

Description

Fix bug where multi select tool is able to select nodes and notes that are filtered.

Issues

Closes #71

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

@louisgreiner louisgreiner added the bug Something isn't working label Apr 9, 2024
@louisgreiner louisgreiner self-assigned this Apr 9, 2024
@louisgreiner louisgreiner requested a review from aiAdrian as a code owner April 9, 2024 08:51
@louisgreiner
Copy link
Collaborator Author

I am not sure that issue II. (from issue #71) is relevant to solve actually

@louisgreiner
Copy link
Collaborator Author

Is there any more tests that need to be implemented ?

aiAdrian
aiAdrian approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@aiAdrian aiAdrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to fix the bug. And fixing the typos.

@aiAdrian aiAdrian merged commit deb7cd1 into main Apr 9, 2024
8 checks passed
@aiAdrian aiAdrian deleted the fix-multiselection-on-filtered-nodes branch April 9, 2024 10:04
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Merged
This was referenced Apr 22, 2024
Merged
Merged
This was referenced Aug 6, 2024
Merged
Closed
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiAdrian aiAdrian aiAdrian approved these changes

Assignees

@louisgreiner louisgreiner

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Multi-selection (right-click drag) tool selection on labeled nodes
2 participants
@louisgreiner @aiAdrian