Long email addresses cause incorrect formatting of the left sidebar change history - resolved #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
| .user-id { | ||
| width: 140px; /* Set the desired width */ | ||
| overflow: auto; /* Hide overflowing content */ | ||
| text-overflow: ellipsis; /* Display ellipsis (...) for overflow */ |
There was a problem hiding this comment.
As the input field doesn't show "asupersuperlongem..."but "asupersuperlongem", you might just comment that the email overflows, but doesn't display "..."
There was a problem hiding this comment.
I have overworked the "UX concept" - now the email address gets copied and the log service shows a toast to inform you that the email address was copied. The copied function is as well active, when user clicks on the comments.
emersion
reviewed
Aug 20, 2024
...ariant/variant-view/variant-history/version-entry-layout/version-entry-layout.component.scss
Outdated
Show resolved
Hide resolved
emersion
reviewed
Aug 20, 2024
...ariant/variant-view/variant-history/version-entry-layout/version-entry-layout.component.scss
Outdated
Show resolved
Hide resolved
…netzgrafik-editor-frontend into 243-bug-long-email-addresses-cause-incorrect-formatting-of-the-left-sidebar-change-history
…ows a toast to inform the user that the email address was copied.
…netzgrafik-editor-frontend into 243-bug-long-email-addresses-cause-incorrect-formatting-of-the-left-sidebar-change-history
louisgreiner
approved these changes
Aug 20, 2024
emersion
reviewed
Aug 20, 2024
Comment on lines
+57
to
+59
| navigator.clipboard.writeText(userId); | ||
| const msg = $localize`:@@app.view.variant.variant-view.variant-history.version-entry-layout.user-id-copied:copied ${userId}:msg:`; | ||
| this.logService.info(msg); |
There was a problem hiding this comment.
Suggested change: use await navigator.clipboard.writeText() to only show the info message once the text has successfully been copied to the clipboard. (In some cases it can take a while or fail.)
aiAdrian
deleted the
243-bug-long-email-addresses-cause-incorrect-formatting-of-the-left-sidebar-change-history
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
before
after fix
The user can scroll by selecting to copy the email address.
Checklist
documentation/