Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1306 causes a regression in nested list alignment #1463

Open
Sub6Resources opened this issue Mar 11, 2025 · 1 comment
Open

#1306 causes a regression in nested list alignment #1463

Sub6Resources opened this issue Mar 11, 2025 · 1 comment
Labels
bug Something isn't working lists Issues with <ol>, <ul>, and <li>

Comments

@Sub6Resources
Copy link
Owner

          This PR causes a regression in nested list alignment in the following HTML snippet.
<div> <ol> <li> <ul> <li>to read</li> </ul> <div> <div> <div> <div> ミルトンの <ruby><rt>さく</rt> </ruby> <ruby><rt>ひん</rt> </ruby><span>読んだ</span>ことがありますか。 </div> <div>Have you ever read Milton's works? <span>[1]</span></div> </div> </div> </div> </li> <li> <ul> <li>to recite (e.g. a sutra)</li> <li>to chant</li> </ul> </li> <li> <ul> <li>to predict</li> <li>to guess</li> <li>to forecast</li> <li>to read (someone's thoughts)</li> <li>to see (e.g. into someone's heart)</li> <li>to divine</li> </ul> <div> <div> <div> <div> <ruby><rt>かの</rt> </ruby> <ruby><rt>じょ</rt> </ruby><ruby><rt>こころ</rt> </ruby><ruby><rt>うご</rt> </ruby>きを <span>読む</span>ことさえできなかった。 </div> <div> I could not even make a guess at the working of her mind. <span>[2]</span> </div> </div> </div> </div> </li> <li> <ul> <li>to pronounce</li> <li>to read (e.g. a kanji)</li> </ul> </li> <li> <ul> <li>to decipher</li> <li>to read (a meter, graph, music, etc.)</li> <li>to tell (the time)</li> </ul> <div> <div> <div> <div> <ruby><rt>わたし</rt> </ruby><ruby><rt>あたま</rt> </ruby><ruby><rt>がく</rt> </ruby> <ruby><rt></rt> </ruby><span>読む</span>ようにはよく <ruby><rt></rt> </ruby>らされて <ruby><rt></rt> </ruby>りますが、どうも <ruby><rt>あん</rt> </ruby> <ruby><rt>ごう</rt> </ruby><span>読む</span>には <ruby><rt>てき</rt> </ruby>しません。 </div> <div> My mind is quite accustomed to reading music, but deciphering secret codes is not its forte. <span>[3]</span> </div> </div> </div> </div> </li> <li> <ul> <li>to count</li> <li>to estimate</li> </ul> <div> <div> <div>Note</div> <div>now mostly used in idioms</div> </div> <div> <div> <div> <span>See:</span> <a> <span >さばを <ruby><rt></rt> </ruby></span> </a> </div> <div> to manipulate figures to one's advantage; to count wrongly on purpose; to inflate or deflate one's age </div> </div> </div> </div> </li> <li> <ul> <li>to read (a kanji) with its native Japanese reading</li> </ul> <div> <div> <div>Note</div> <div>also written as 訓む</div> </div> </div> </li> </ol> </div>

3.0.0-beta.2 (Expected)

2024-07-02T02:21:59,066791377+08:00

Result on this PR

2024-07-02T02:21:07,335303148+08:00

Originally posted by @shovel-kun in #1306 (comment)

@Sub6Resources
Copy link
Owner Author

Added a rough fix in #1468 that gets us roughly back to the 3.0.0-beta.2 behavior. The core issue is unfortunately quite nuanced, so a better fix may take quite a bit of work. Unfortunately probably not a high priority issue (especially since the official CSS spec doesn't actually specify exactly how the markers on list items with block children should be placed)

@Sub6Resources Sub6Resources added bug Something isn't working lists Issues with <ol>, <ul>, and <li> labels Mar 12, 2025
@Sub6Resources Sub6Resources moved this to Todo in flutter_html Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lists Issues with <ol>, <ul>, and <li>
Projects
Status: Todo
Development

No branches or pull requests

1 participant