From b6476cc3164a86df6a9f942a9a9f773668876d02 Mon Sep 17 00:00:00 2001
From: Nabil Adouani <nabil.adouani@gmail.com>
Date: Wed, 4 Apr 2018 17:15:26 +0200
Subject: [PATCH] #82 Display invalid analyzers an allow removing them

---
 .../components/analyzers-list.controller.js   |  3 +++
 .../components/analyzers-list.html            | 23 +++++++++++++++++++
 2 files changed, 26 insertions(+)

diff --git a/www/src/app/pages/admin/organizations/components/analyzers-list.controller.js b/www/src/app/pages/admin/organizations/components/analyzers-list.controller.js
index 2f4301b2f..74c8d813a 100644
--- a/www/src/app/pages/admin/organizations/components/analyzers-list.controller.js
+++ b/www/src/app/pages/admin/organizations/components/analyzers-list.controller.js
@@ -33,6 +33,9 @@ export default class OrganizationAnalyzersController {
   $onInit() {
     this.activeAnalyzers = _.keyBy(this.analyzers, 'analyzerDefinitionId');
     this.definitionsIds = _.keys(this.analyzerDefinitions).sort();
+    this.invalidAnalyzers = _.filter(this.analyzers, a =>
+      _.isEmpty(a.dataTypeList)
+    );
   }
 
   openModal(mode, definition, analyzer) {
diff --git a/www/src/app/pages/admin/organizations/components/analyzers-list.html b/www/src/app/pages/admin/organizations/components/analyzers-list.html
index 1bc27f577..4747c314a 100644
--- a/www/src/app/pages/admin/organizations/components/analyzers-list.html
+++ b/www/src/app/pages/admin/organizations/components/analyzers-list.html
@@ -1,4 +1,27 @@
 <section>
+
+  <div class="mb-s" ng-if="$ctrl.invalidAnalyzers.length > 0">
+      <div class="callout callout-warning">
+        <h4>You have {{$ctrl.invalidAnalyzers.length}} invalid <ng-pluralize count="$ctrl.invalidAnalyzers.length" when="{'1': 'analyzer', 'other': 'analyzers'}"></ng-pluralize></h4>        
+        <p>Invalid analyzers have no definition and cannot be run on any observable. You have to remove them.</p>
+      </div>
+      <div class="row">
+        <div class="col-sm-12 flex-table">
+          <div class="flex-row media" ng-repeat="a in $ctrl.invalidAnalyzers">
+            <div class="flex-col flex-1">
+              <h4 class="media-heading">
+                <span class="mr-m text-primary">{{a.name}}</span>
+              </h4>
+            </div>
+            <div class="flex-col flex-icon flex-w-100 text-center" ng-click="$ctrl.disable(a.id)">
+              <a href class="text-danger">
+                <i class="fa fa-ban"></i>Disable</a>
+            </div>
+          </div>
+        </div>
+      </div>      
+  </div>
+
   <p class="lead">Available analyzers ({{$ctrl.definitionsIds.length || 0}}) <a href class="pull-right btn btn-primary" ng-click="$ctrl.refreshAnalyzers()"><i class="fa fa-refresh"></i> Refresh analyzers</a></p>
 
   <div class="row mv-s" ng-if="$ctrl.definitionsIds.length === 0">