Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install python3 requirements for analyzers in public docker image #58

Closed
0xmilkmix opened this issue Dec 29, 2017 · 5 comments
Closed
Assignees
Labels
Milestone

Comments

@0xmilkmix
Copy link

Request Type

Bug / Feature Request

Work Environment

Question Answer
OS version (server) OS running docker
Cortex version / git hash latest public docker image / 1.1.4
Package Type Docker

Problem Description

Some analyzers written in python3 are not working with the public Docker image provided for Cortex. The reason is that the requirements are installed with pip for python2 in Cortex/build.sbt:147

Only misp-analyzer requirements are installed with pip3. Shodan is also using python3.

Steps to Reproduce

  1. docker pull certbdf/cortex
  2. docker run cortex bash
  3. python3 -c 'import cortexutils'

Possible Solutions

  1. Add python version in analyzer definition so that the builder knowns which version of pip to use to install requirements
@ilyaglow
Copy link

As a workaround you can base your own Dockerfile on certbdf/cortex and install whatever needed

@0xmilkmix
Copy link
Author

will try to code something as a poc and provide a pull request if successful

@rayschippers
Copy link

rayschippers commented Apr 10, 2018

@0xmilkmix how did you go? This would be easier if there was public dockerfiles for the The Hive. Does anyone know what variant of base docker images these images use so I can use the relevant command to install python3.

@0xmilkmix
Copy link
Author

didn't had the time to work on it. Also, I need to learn scala/sbt basics before doing this small if/else condition :)

@To-om
Copy link
Contributor

To-om commented Apr 10, 2018

Fixed in the release 2.0.3

@To-om To-om closed this as completed Apr 10, 2018
@To-om To-om added the bug label Apr 13, 2018
@To-om To-om added this to the 2.0.4 milestone Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants