From 53e7c8258ff25fb5cb9ae4a584ceafeee1f63435 Mon Sep 17 00:00:00 2001
From: To-om <toom@thehive-project.org>
Date: Wed, 19 May 2021 14:46:56 +0200
Subject: [PATCH] #1982 Prevent failure when an observable cannot be imported
 from job

---
 .../connector/cortex/services/JobSrv.scala    | 49 +++++++++++--------
 1 file changed, 28 insertions(+), 21 deletions(-)

diff --git a/cortex/connector/src/main/scala/org/thp/thehive/connector/cortex/services/JobSrv.scala b/cortex/connector/src/main/scala/org/thp/thehive/connector/cortex/services/JobSrv.scala
index 8fa24cfd25..322b750e4a 100644
--- a/cortex/connector/src/main/scala/org/thp/thehive/connector/cortex/services/JobSrv.scala
+++ b/cortex/connector/src/main/scala/org/thp/thehive/connector/cortex/services/JobSrv.scala
@@ -15,7 +15,7 @@ import org.thp.scalligraph.models.{Database, Entity}
 import org.thp.scalligraph.services._
 import org.thp.scalligraph.traversal.TraversalOps._
 import org.thp.scalligraph.traversal.{Converter, Graph, StepLabel, Traversal}
-import org.thp.scalligraph.{EntityId, EntityIdOrName, NotFoundError}
+import org.thp.scalligraph.{CreateError, EntityId, EntityIdOrName, NotFoundError}
 import org.thp.thehive.connector.cortex.controllers.v0.Conversion._
 import org.thp.thehive.connector.cortex.models._
 import org.thp.thehive.connector.cortex.services.Conversion._
@@ -32,7 +32,7 @@ import java.nio.file.Files
 import java.util.{Date, Map => JMap}
 import javax.inject.{Inject, Singleton}
 import scala.concurrent.{ExecutionContext, Future}
-import scala.util.{Failure, Success, Try}
+import scala.util.{Success, Try}
 
 @Singleton
 class JobSrv @Inject() (
@@ -218,21 +218,28 @@ class JobSrv @Inject() (
       .flatMap(_.artifacts)
     Future
       .traverse(artifacts) { artifact =>
-        db.tryTransaction(graph => observableTypeSrv.getOrFail(EntityIdOrName(artifact.dataType))(graph)) match {
-          case Success(attachmentType) if attachmentType.isAttachment => importCortexAttachment(job, artifact, cortexClient)
-          case _: Success[_] =>
-            Future
-              .fromTry {
-                db.tryTransaction { implicit graph =>
-                  for {
-                    origObs <- get(job).observable.getOrFail("Observable")
-                    obs     <- observableSrv.create(artifact.toObservable(job._id, origObs.organisationIds), artifact.data.get)
-                    _       <- addObservable(job, obs.observable)
-                  } yield ()
-                }
-              }
-          case Failure(e) => Future.failed(e)
-        }
+        db.tryTransaction(graph => observableTypeSrv.getOrFail(EntityIdOrName(artifact.dataType))(graph))
+          .fold(
+            Future.failed,
+            {
+              case attachmentType if attachmentType.isAttachment => importCortexAttachment(job, artifact, cortexClient)
+              case _ =>
+                Future
+                  .fromTry {
+                    db.tryTransaction { implicit graph =>
+                      for {
+                        origObs <- get(job).observable.getOrFail("Observable")
+                        obs     <- observableSrv.create(artifact.toObservable(job._id, origObs.organisationIds), artifact.data.get)
+                        _       <- addObservable(job, obs.observable)
+                      } yield ()
+                    }
+                  }
+            }
+          )
+          .recover {
+            case _: CreateError =>
+            case error          => logger.error("Fail to import observable from Job", error)
+          }
       }
       .map(_ => Done)
   }
@@ -257,7 +264,7 @@ class JobSrv @Inject() (
       cortexClient: CortexClient
   )(implicit
       authContext: AuthContext
-  ): Future[Attachment with Entity] =
+  ): Future[Unit] =
     artifact
       .attachment
       .map { attachment =>
@@ -266,17 +273,17 @@ class JobSrv @Inject() (
           src <- cortexClient.getAttachment(attachment.id)
           _   <- src.runWith(FileIO.toPath(file))
           fFile = FFile(attachment.name.getOrElse(attachment.id), file, attachment.contentType.getOrElse("application/octet-stream"))
-          savedAttachment <- Future.fromTry {
+          _ <- Future.fromTry {
             db.tryTransaction { implicit graph =>
               for {
                 origObs           <- get(job).observable.getOrFail("Observable")
                 createdAttachment <- attachmentSrv.create(fFile)
                 richObservable    <- observableSrv.create(artifact.toObservable(job._id, origObs.organisationIds), createdAttachment)
                 _                 <- reportObservableSrv.create(ReportObservable(), job, richObservable.observable)
-              } yield createdAttachment
+              } yield ()
             }
           }
-        } yield savedAttachment)
+        } yield ())
           .andThen { case _ => Files.delete(file) }
       }
       .getOrElse(Future.failed(new Exception(s"Attachment not present for artifact ${artifact.dataType}")))