From 5b1af82917c28e40a685284038dc868043968804 Mon Sep 17 00:00:00 2001
From: To-om <toom@thehive-project.org>
Date: Mon, 21 Dec 2020 15:10:08 +0100
Subject: [PATCH] #1718 Fix duplication checks when creating an observable

---
 thehive/app/org/thp/thehive/services/CaseSrv.scala | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/thehive/app/org/thp/thehive/services/CaseSrv.scala b/thehive/app/org/thp/thehive/services/CaseSrv.scala
index 7acf6b7358..9e1ffacd3f 100644
--- a/thehive/app/org/thp/thehive/services/CaseSrv.scala
+++ b/thehive/app/org/thp/thehive/services/CaseSrv.scala
@@ -176,18 +176,8 @@ class CaseSrv @Inject() (
       authContext: AuthContext
   ): Try[Unit] = {
     val alreadyExistInThatCase = richObservable
-      .dataOrAttachment
-      .fold(
-        _ =>
-          observableSrv
-            .get(richObservable.observable)
-            .filteredSimilar
-            .visible
-            .`case`
-            .hasId(`case`._id)
-            .exists,
-        attachment => get(`case`).share.observables.attachments.has(_.attachmentId, attachment.attachmentId).exists
-      ) || get(`case`).observables.filter(_.hasId(richObservable.observable._id)).exists
+      .data
+      .fold(false)(data => get(`case`).observables.data.has(_.data, data.data).exists)
 
     if (alreadyExistInThatCase)
       Failure(CreateError("Observable already exists"))