From 73ee9616d798b27e58de748f11ae58427f3f2850 Mon Sep 17 00:00:00 2001
From: Nabil Adouani <nabil.adouani@gmail.com>
Date: Thu, 16 Jul 2020 16:51:48 +0200
Subject: [PATCH] #1432 Allow user without manageShare to see the tasks and
 observables shares without allowing them to add new shares

---
 frontend/app/views/partials/case/case.sharing.html        | 2 +-
 frontend/app/views/partials/case/case.tasks.item.html     | 8 +++++---
 .../app/views/partials/observables/details/sharing.html   | 6 +++---
 .../app/views/partials/observables/details/summary.html   | 3 ++-
 4 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/frontend/app/views/partials/case/case.sharing.html b/frontend/app/views/partials/case/case.sharing.html
index d0f8bbb0b4..a0b4995ec7 100644
--- a/frontend/app/views/partials/case/case.sharing.html
+++ b/frontend/app/views/partials/case/case.sharing.html
@@ -1,4 +1,4 @@
-<div class="row mb-s" if-permission="manageCase" allowed="{{userPermissions}}">
+<div class="row mb-s" if-permission="manageShare" allowed="{{userPermissions}}">
     <div class="col-md-12">
         <div class="btn-toolbar" role="toolbar">
             <div class="btn-group">
diff --git a/frontend/app/views/partials/case/case.tasks.item.html b/frontend/app/views/partials/case/case.tasks.item.html
index f0349a5197..56ce0cd30e 100644
--- a/frontend/app/views/partials/case/case.tasks.item.html
+++ b/frontend/app/views/partials/case/case.tasks.item.html
@@ -3,7 +3,8 @@ <h4 class="mb-xs text-primary">
         Basic Information
 
         <div class="task-actions pull-right" if-permission="manageTask" allowed="{{userPermissions}}">
-            <span if-permission="manageShare" allowed="{{userPermissions}}">
+            <!-- <span if-permission="manageShare" allowed="{{userPermissions}}"> -->
+            <span>
                 <a href ng-click="scrollTo('#task-sharings')">
                     <span class="mr-xxs action-button">
                         <i class="fa fa-users"></i> Sharing
@@ -220,9 +221,10 @@ <h4 class="vpad10 text-primary">Task logs</h4>
         <psearch control="logs"></psearch>
     </div>
 
-    <div class="col-md-12" id="task-sharings" if-permission="manageShare" allowed="{{userPermissions}}">
+    <!-- <div class="col-md-12" id="task-sharings" if-permission="manageShare" allowed="{{userPermissions}}"> -->
+    <div class="col-md-12" id="task-sharings">
          <h4 class="vpad10 text-primary">Task sharing</h4>
-         <div class="btn-toolbar" role="toolbar">
+         <div class="btn-toolbar" role="toolbar" if-permission="manageShare" allowed="{{userPermissions}}">
              <div class="btn-group">
                  <button class="btn btn-sm btn-primary" ng-click="addTaskShare()">
                      <i class="fa fa-plus"></i>
diff --git a/frontend/app/views/partials/observables/details/sharing.html b/frontend/app/views/partials/observables/details/sharing.html
index d3350684dd..cfb58c7ff5 100644
--- a/frontend/app/views/partials/observables/details/sharing.html
+++ b/frontend/app/views/partials/observables/details/sharing.html
@@ -1,7 +1,7 @@
 <div class="row">
-    <div class="col-md-12" id="observable-sharings" if-permission="manageShare" allowed="{{userPermissions}}">
+    <div class="col-md-12" id="observable-sharings">
          <h4 class="vpad10 text-primary">Sharing</h4>
-         <div class="btn-toolbar" role="toolbar">
+         <div class="btn-toolbar" role="toolbar" if-permission="manageShare" allowed="{{userPermissions}}">
              <div class="btn-group">
                  <button class="btn btn-sm btn-primary" ng-click="addTaskShare()">
                      <i class="fa fa-plus"></i>
@@ -14,7 +14,7 @@ <h4 class="vpad10 text-primary">Sharing</h4>
                  shares="shares"
                  read-only="true"
                  on-delete="removeShare(share)"
-                 permissions="userPermissions"                 
+                 permissions="userPermissions"
                  ></sharing-list>
          </div>
     </div>
diff --git a/frontend/app/views/partials/observables/details/summary.html b/frontend/app/views/partials/observables/details/summary.html
index 52a58de773..3a5e168b0d 100644
--- a/frontend/app/views/partials/observables/details/summary.html
+++ b/frontend/app/views/partials/observables/details/summary.html
@@ -4,7 +4,8 @@
         <h4 class="vpad10 text-primary">
             Metadata
             <div class="task-actions pull-right">
-                <span if-permission="manageShare" allowed="{{userPermissions}}">
+                <!-- <span if-permission="manageShare" allowed="{{userPermissions}}"> -->
+                <span>
                     <a href ng-click="scrollTo('#observable-sharings')">
                         <span class="mr-xxs action-button">
                             <i class="fa fa-users"></i> Sharing