Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Improve CustomFields support when merging alert into cases #1647

Open
smogm opened this issue Nov 13, 2020 · 5 comments
Open
Assignees
Labels
feature request TheHive4 TheHive4 related issues

Comments

@smogm
Copy link

smogm commented Nov 13, 2020

Request Type

Feature Request

Problem Description

When merging multiple alerts into one case only the customFields of the most recent alert will be merged into the created case.
Thus you will lose important information about the original alerts.

This is very anoying, if you have a SIEM system and try to push back changes on the case.

Example:

{
	'_id': '~8400', 
	'id': '~8400', 
       [...]
	'_type': 'case', 
	'owner': '<redacted>', 
	'customFields': {
		'incidentId': {'string': '5fae7cd89494cff924d69f70', 'order': 0}, 
		'poolId': {'string': 'b2b4b1056fbe40d390ee73726bcbc82f', 'order': 1}, 
		'machineId': {'string': '63c78c10c23b7a19c8669f597e0cd8ce', 'order': 2}, 
		'assignedTo': {'string': 'alert_test', 'order': 4}, 
		'alertId': {'string': '5f75c679af21da8c9ee55005', 'order': 3}
	}, 
	'stats': {}, 
	'permissions': ['manageShare', 'manageAnalyse', 'manageTask', 'manageCaseTemplate', 'manageCase', 'manageUser', 'managePage', 'manageObservable', 'manageConfig', 'manageAlert', 'manageAction']
}

In case of a merged case the customeFields object should hold an array or list of the customFields of all merged alerts. Maybe also use the _type field to indicate a merged case:

{
	'_id': '~8400', 
	'id': '~8400', 
	[...]
	'_type': 'mergedCase',
	'owner': '<redacted>', 
	'customFields': [ 
		'~122900568': {    # <=== alert id
			'incidentId': {'string': '5fae7cd89494cff924d69f70', 'order': 0}, 
			'poolId': {'string': 'b2b4b1056fbe40d390ee73726bcbc82f', 'order': 1}, 
			'machineId': {'string': '63c78c10c23b7a19c8669f597e0cd8ce', 'order': 2}, 
			'assignedTo': {'string': 'alert_test', 'order': 4}, 
			'alertId': {'string': '5f75c679af21da8c9ee55005', 'order': 3}
		},
		'~122900570': {    # <=== alert id
			'incidentId': {'string': '5fae7cd89494cff924d69f71', 'order': 0}, 
			'poolId': {'string': 'b2b4b1056fbe40d390ee73726bcbc82f', 'order': 1}, 
			'machineId': {'string': '63c78c10c23b7a19c8669f597e0cd8ce', 'order': 2}, 
			'assignedTo': {'string': 'alert_test', 'order': 4}, 
			'alertId': {'string': '5f75c679af21da8c9ee55005', 'order': 3}
		}
	],
	'stats': {}, 
	'permissions': ['manageShare', 'manageAnalyse', 'manageTask', 'manageCaseTemplate', 'manageCase', 'manageUser', 'managePage', 'manageObservable', 'manageConfig', 'manageAlert', 'manageAction']
}
@smogm smogm added TheHive4 TheHive4 related issues bug labels Nov 13, 2020
@nadouani
Copy link
Contributor

Hello @smogm What version of TheHive?

@smogm
Copy link
Author

smogm commented Nov 16, 2020

Hello @nadouani, I'm currently at 4.0.1.

It would also be enough to have a list of the alert ids the case was created from. And add this to the API too.

@nadouani nadouani self-assigned this Nov 16, 2020
@nadouani nadouani added this to the 4.0.2 milestone Nov 16, 2020
@nadouani nadouani removed this from the 4.0.2 milestone Nov 17, 2020
@nadouani
Copy link
Contributor

This sounds like supporting multi valued custom fields, not an issue in merging alerts into cases. This is a valid feature request that needs to be planned.

@smogm
Copy link
Author

smogm commented Nov 17, 2020

@nadouani Thank you!
As I said, it would also be good to have the origin alert ids as a new multi valued field. Thus you can use the sourceRef field of the alert to store the identifier of the SIEM system and sync commets or resultion information from TheHive back to the SIEM.
For this use case, the latter seems to be the better solution.

@nadouani nadouani changed the title [Feature Request] CustomFields not merged correctly from alerts into case? [Feature Request] Improve CustomFields support when merging alert into cases Nov 18, 2020
@smogm
Copy link
Author

smogm commented Nov 26, 2020

Hello @nadouani,

do you have any news on that front or an estimation in which milestone you will add this feature enhancement?

We really would like to see it as soon as possible as we use TheHive in a productive environment and need to sync case-changes back to our SIEM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request TheHive4 TheHive4 related issues
Projects
None yet
Development

No branches or pull requests

2 participants