Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MISP event filter require manual escapes #87

Closed
derDuffy opened this issue Jan 12, 2017 · 2 comments
Closed

MISP event filter require manual escapes #87

derDuffy opened this issue Jan 12, 2017 · 2 comments
Assignees
Milestone

Comments

@derDuffy
Copy link

Request Type

Bug

Problem Description

The filter for MISP events produces errors if certain characters are not manually escaped before filtering.
This is for example the case if one would like to filter for a tlp tag like tlp:green it will only work if one searches for tlp\:green otherwise shared errors will appear.

Steps to Reproduce

  1. Navigate to the MISP events page
  2. Filter for colon
@nadouani
Copy link
Contributor

Hi @derDuffy, the issue here is that the colon is a "reserved" character, I mean that we cannot escape it since it should not for queries like field:value(example: eventStatus:New).

This requires us to implement a query syntax parser and validator, which is not something with "low priority" if we provide a more elaborated filter form, as described in #86

To escape the field values that contains reserved chars, make sure to wrap the value with quotes: tags:"tlp:white"

@nadouani nadouani self-assigned this Jan 13, 2017
@nadouani nadouani added this to the 2.11.0 milestone Jan 13, 2017
@nadouani
Copy link
Contributor

Closing as duplicate of #86 where we will add a new filtering form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants