Skip to content

Commit 054b203

Browse files
cexbrayatfilipesilva
authored andcommitted
fix(@angular/cli): bump jasmine and add jasminewd2 types
This bumps jasmine types to 2.5.53. The version was previously pinned down to 2.5.45, because more recent versions weren't playing nice with Protractor and lead to errors like angular/protractor#4176 The proper fix appears to be the one mentioned in the Protractor issue: add `@types/jasminewd2` typings, and add these typings to the tsconfig for e2e tests. [jasminewd](https://github.com/angular/jasminewd) is the adapter used by Protractor to handle the async part.
1 parent 1f3738b commit 054b203

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

packages/@angular/cli/blueprints/ng/files/e2e/tsconfig.e2e.json

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"target": "es5",
77
"types": [
88
"jasmine",
9+
"jasminewd2",
910
"node"
1011
]
1112
}

packages/@angular/cli/blueprints/ng/files/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@
3232
"@angular/cli": "<%= version %>",
3333
"@angular/compiler-cli": "^4.0.0",
3434
"@angular/language-service": "^4.0.0",<% if (!minimal) { %>
35-
"@types/jasmine": "2.5.45",
35+
"@types/jasmine": "~2.5.53",
36+
"@types/jasminewd2": "~2.0.2",
3637
"@types/node": "~6.0.60",
3738
"codelyzer": "~3.0.1",
3839
"jasmine-core": "~2.6.2",

0 commit comments

Comments
 (0)