fix(@angular/cli): allow node_modules to be linked somewhere else.

Fixes #6499.

Author: hansl

packages/@angular/cli/models/webpack-configs/browser.ts

@@ -1,3 +1,4 @@
+import * as fs from 'fs';
 import * as webpack from 'webpack';
 import * as path from 'path';
 const HtmlWebpackPlugin = require('html-webpack-plugin');
@@ -24,14 +25,20 @@ export function getBrowserConfig(wco: WebpackConfigOptions) {
   if (buildOptions.vendorChunk) {
     // Separate modules from node_modules into a vendor chunk.
     const nodeModules = path.resolve(projectRoot, 'node_modules');
+    // Resolves all symlink to get the actual node modules folder.
+    const realNodeModules = fs.realpathSync(nodeModules);
     // --aot puts the generated *.ngfactory.ts in src/$$_gendir/node_modules.
     const genDirNodeModules = path.resolve(appRoot, '$$_gendir', 'node_modules');
 
     extraPlugins.push(new webpack.optimize.CommonsChunkPlugin({
       name: 'vendor',
       chunks: ['main'],
-      minChunks: (module: any) => module.resource &&
-        (module.resource.startsWith(nodeModules) || module.resource.startsWith(genDirNodeModules))
+      minChunks: (module: any) => {
+        return module.resource
+            && (   module.resource.startsWith(nodeModules)
+                || module.resource.startsWith(genDirNodeModules)
+                || module.resource.startsWith(realNodeModules));
+      }
     }));
   }
 

packages/@angular/cli/tasks/eject.ts

@@ -35,10 +35,12 @@ const pree2eNpmScript = `webdriver-manager update --standalone false --gecko fal
 class JsonWebpackSerializer {
   public imports: {[name: string]: string[]} = {};
   public variableImports: {[name: string]: string} = {
-    'path': 'path'
+    'fs': 'fs',
+    'path': 'path',
   };
   public variables: {[name: string]: string} = {
     'nodeModules': `path.join(process.cwd(), 'node_modules')`,
+    'realNodeModules': `fs.realpathSync(nodeModules)`,
     'genDirNodeModules':
       `path.join(process.cwd(), '${this._appRoot}', '$$_gendir', 'node_modules')`,
   };

tests/e2e/tests/build/vendor-chunk-symlink-node-module.ts

@@ -0,0 +1,22 @@
+import {ng} from '../../utils/process';
+import {deleteFile, expectFileToExist, moveFile, symlinkFile} from '../../utils/fs';
+
+
+// THIS TEST REQUIRES TO MOVE NODE_MODULES AND MOVE IT BACK.
+export default function() {
+  return Promise.resolve()
+    .then(() => moveFile('node_modules', '../node_modules'))
+    .then(() => symlinkFile('../node_modules', 'node_modules', 'dir'))
+    .then(() => ng('build'))
+    .then(() => expectFileToExist('dist/vendor.bundle.js'))
+    .then(() => expectFileToExist('dist/vendor.bundle.js.map'))
+    // Cleanup
+    .then(() => {
+      return deleteFile('node_modules')
+        .then(() => moveFile('../node_modules', 'node_modules'));
+    }, (err: any) => {
+      return deleteFile('node_modules')
+        .then(() => moveFile('../node_modules', 'node_modules'))
+        .then(() => { throw err; });
+    })
+}

tests/e2e/utils/fs.ts

@@ -67,6 +67,19 @@ export function moveFile(from: string, to: string) {
   });
 }
 
+
+export function symlinkFile(from: string, to: string, type?: string) {
+  return new Promise<void>((resolve, reject) => {
+    fs.symlink(from, to, type, (err) => {
+      if (err) {
+        reject(err);
+      } else {
+        resolve();
+      }
+    });
+  });
+}
+
 export function createDir(path: string) {
   _recursiveMkDir(path);
 }