fix(@angular/cli): baseHref to accept empty string via cli

sendilkumarn · hansl · commit 2486bf9cdd96 · 2017-08-03T11:20:29.000-07:00
diff --git a/packages/@angular/cli/lib/base-href-webpack/base-href-webpack-plugin.spec.ts b/packages/@angular/cli/lib/base-href-webpack/base-href-webpack-plugin.spec.ts
@@ -63,4 +63,19 @@ describe('base href webpack plugin', () => {
     });
     plugin.apply(compiler);
   });
+
+  it('should replace href attribute when baseHref is empty', function () {
+    const plugin = new BaseHrefWebpackPlugin({ baseHref: '' });
+
+    const compiler = mockCompiler(oneLineTrim`
+          <head><base href="/" target="_blank"></head>
+          <body></body>
+        `, (_x: any, htmlPluginData: any) => {
+      expect(htmlPluginData.html).toEqual(oneLineTrim`
+          <head><base href="" target="_blank"></head>
+          <body></body>
+        `);
+    });
+    plugin.apply(compiler);
+  });
 });
diff --git a/packages/@angular/cli/lib/base-href-webpack/base-href-webpack-plugin.ts b/packages/@angular/cli/lib/base-href-webpack/base-href-webpack-plugin.ts
@@ -7,7 +7,7 @@ export class BaseHrefWebpackPlugin {
 
   apply(compiler: any): void {
     // Ignore if baseHref is not passed
-    if (!this.options.baseHref) {
+    if (!this.options.baseHref && this.options.baseHref !== '') {
       return;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ export class BaseHrefWebpackPlugin {`
`7`	`7`
`8`	`8`	`apply(compiler: any): void {`
`9`	`9`	`// Ignore if baseHref is not passed`
`10`		`- if (!this.options.baseHref) {`
	`10`	`+ if (!this.options.baseHref && this.options.baseHref !== '') {`
`11`	`11`	`return;`
`12`	`12`	`}`
`13`	`13`