Skip to content

Commit 504b00b

Browse files
committed
fix(@angular-devkit/build-angular): clear context in Karma by default for single run executions
This works around #28271. (cherry picked from commit 3ee2163)
1 parent 82b7608 commit 504b00b

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

packages/angular_devkit/build_angular/src/builders/karma/index.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,12 @@ export function execute(
9898

9999
karmaOptions.singleRun = singleRun;
100100

101+
// Workaround https://github.com/angular/angular-cli/issues/28271, by clearing context by default
102+
// for single run executions. Not clearing context for multi-run (watched) builds allows the
103+
// Jasmine Spec Runner to be visible in the browser after test execution.
104+
karmaOptions.client ??= {};
105+
karmaOptions.client.clearContext ??= singleRun ?? false; // `singleRun` defaults to `false` per Karma docs.
106+
101107
// Convert browsers from a string to an array
102108
if (typeof options.browsers === 'string' && options.browsers) {
103109
karmaOptions.browsers = options.browsers.split(',');
@@ -208,9 +214,6 @@ function getBuiltInKarmaConfig(
208214
'karma-coverage',
209215
'@angular-devkit/build-angular/plugins/karma',
210216
].map((p) => workspaceRootRequire(p)),
211-
client: {
212-
clearContext: false, // leave Jasmine Spec Runner output visible in browser
213-
},
214217
jasmineHtmlReporter: {
215218
suppressAll: true, // removes the duplicated traces
216219
},

packages/schematics/angular/config/files/karma.conf.js.template

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ module.exports = function (config) {
1919
// for example, you can disable the random execution with `random: false`
2020
// or set a specific seed with `seed: 4321`
2121
},
22-
clearContext: false // leave Jasmine Spec Runner output visible in browser
2322
},
2423
jasmineHtmlReporter: {
2524
suppressAll: true // removes the duplicated traces

0 commit comments

Comments
 (0)