Skip to content

Commit 6020803

Browse files
josephperrottclydin
josephperrott
authored and
clydin
committed
build: disable failing strict_deps targets
Disable all failing strict_deps targets with TODOs to fix them moving forward.
1 parent d09236e commit 6020803

File tree

12 files changed

+65
-4
lines changed

12 files changed

+65
-4
lines changed

‎packages/angular/build/BUILD.bazel

+8
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ ts_project(
6161
"//packages/angular/build:src/builders/ng-packagr/schema.ts",
6262
],
6363
data = RUNTIME_ASSETS,
64+
# TODO: Fix strict_deps failure
65+
ignore_strict_deps = True,
6466
module_name = "@angular/build",
6567
deps = [
6668
":node_modules/@angular-devkit/architect",
@@ -121,6 +123,8 @@ ts_project(
121123
include = ["src/**/*_spec.ts"],
122124
exclude = ["src/builders/**/tests/**"],
123125
),
126+
# TODO: Fix strict_deps failure
127+
ignore_strict_deps = True,
124128
deps = [
125129
":build_rjs",
126130
"//:node_modules/@angular/compiler-cli",
@@ -141,6 +145,8 @@ ts_project(
141145
name = "application_integration_test_lib",
142146
testonly = True,
143147
srcs = glob(include = ["src/builders/application/tests/**/*.ts"]),
148+
# TODO: Fix strict_deps failure
149+
ignore_strict_deps = True,
144150
deps = [
145151
":build_rjs",
146152
"//packages/angular/build/private:private_rjs",
@@ -167,6 +173,8 @@ ts_project(
167173
name = "dev-server_integration_test_lib",
168174
testonly = True,
169175
srcs = glob(include = ["src/builders/dev-server/tests/**/*.ts"]),
176+
# TODO: Fix strict_deps failure
177+
ignore_strict_deps = True,
170178
deps = [
171179
":build_rjs",
172180
"//packages/angular/build/private:private_rjs",

‎packages/angular/cli/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,8 @@ ts_project(
138138
"node_modules/**",
139139
],
140140
),
141+
# TODO: Fix strict_deps failure
142+
ignore_strict_deps = True,
141143
deps = [
142144
":angular-cli_rjs",
143145
"//:node_modules/@types/semver",

‎packages/angular/pwa/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ ts_project(
5050
name = "pwa_test_lib",
5151
testonly = True,
5252
srcs = glob(["pwa/**/*_spec.ts"]),
53+
# TODO: Fix strict_deps failure
54+
ignore_strict_deps = True,
5355
deps = [
5456
":pwa_rjs",
5557
"//:node_modules/@types/jasmine",

‎packages/angular/ssr/node/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ ts_project(
1414
"--types",
1515
"node",
1616
],
17+
# TODO: Fix strict_deps failure
18+
ignore_strict_deps = True,
1719
module_name = "@angular/ssr/node",
1820
source_map = True,
1921
tsconfig = "//:build-tsconfig-esm",

‎packages/angular/ssr/schematics/BUILD.bazel

+4
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ ts_project(
5959
for (src, _) in ALL_SCHEMA_TARGETS
6060
],
6161
data = [":schematics_assets"],
62+
# TODO: Fix strict_deps failure
63+
ignore_strict_deps = True,
6264
module_name = "@angular/ssr/schematics",
6365
deps = [
6466
"//packages/angular_devkit/schematics:schematics_rjs",
@@ -78,6 +80,8 @@ ts_project(
7880
"node_modules/**",
7981
],
8082
),
83+
# TODO: Fix strict_deps failure
84+
ignore_strict_deps = True,
8185
deps = [
8286
":schematics_rjs",
8387
"//:node_modules/@types/node",

‎packages/angular_devkit/architect/testing/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ ts_project(
1515
include = ["**/*.ts"],
1616
exclude = ["**/*_spec.ts"],
1717
),
18+
# TODO: Fix strict_deps failure
19+
ignore_strict_deps = True,
1820
module_name = "@angular-devkit/architect/testing",
1921
deps = [
2022
"//:node_modules/@types/node",

‎packages/angular_devkit/build_angular/BUILD.bazel

+35-4
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,8 @@ ts_project(
122122
"//packages/angular_devkit/build_angular:src/builders/web-test-runner/schema.ts",
123123
],
124124
data = RUNTIME_ASSETS,
125+
# TODO: Fix strict_deps failure
126+
ignore_strict_deps = True,
125127
module_name = "@angular-devkit/build-angular",
126128
deps = [
127129
":node_modules/@angular-devkit/architect",
@@ -218,6 +220,8 @@ ts_project(
218220
data = [
219221
"//packages/angular_devkit/build_angular/test/hello-world-lib",
220222
],
223+
# TODO: Fix strict_deps failure
224+
ignore_strict_deps = True,
221225
deps = [
222226
":build_angular_rjs",
223227
":build_angular_test_utils_rjs",
@@ -289,6 +293,8 @@ ts_project(
289293
data = [
290294
"//packages/angular_devkit/build_angular/test/hello-world-lib",
291295
],
296+
# TODO: Fix strict_deps failure
297+
ignore_strict_deps = True,
292298
deps = [
293299
":build_angular_rjs",
294300
"//:node_modules/@types/jasmine",
@@ -305,8 +311,13 @@ ts_project(
305311
)
306312

307313
LARGE_SPECS = {
308-
"app-shell": {},
314+
"app-shell": {
315+
# TODO: Fix strict_deps failure
316+
"ignore_strict_deps": True,
317+
},
309318
"dev-server": {
319+
# TODO: Fix strict_deps failure
320+
"ignore_strict_deps": True,
310321
"shards": 10,
311322
"size": "large",
312323
"flaky": True,
@@ -318,8 +329,13 @@ LARGE_SPECS = {
318329
"//:node_modules/undici",
319330
],
320331
},
321-
"extract-i18n": {},
332+
"extract-i18n": {
333+
# TODO: Fix strict_deps failure
334+
"ignore_strict_deps": True,
335+
},
322336
"karma": {
337+
# TODO: Fix strict_deps failure
338+
"ignore_strict_deps": True,
323339
"shards": 6,
324340
"size": "large",
325341
"flaky": True,
@@ -334,6 +350,8 @@ LARGE_SPECS = {
334350
],
335351
},
336352
"protractor": {
353+
# TODO: Fix strict_deps failure
354+
"ignore_strict_deps": True,
337355
"extra_deps": [
338356
"//:node_modules/jasmine-spec-reporter",
339357
"//:node_modules/protractor",
@@ -346,13 +364,20 @@ LARGE_SPECS = {
346364
"shards": 1,
347365
},
348366
"server": {
367+
# TODO: Fix strict_deps failure
368+
"ignore_strict_deps": True,
349369
"size": "large",
350370
"extra_deps": [
351371
"//:node_modules/@angular/animations",
352372
],
353373
},
354-
"ng-packagr": {},
374+
"ng-packagr": {
375+
# TODO: Fix strict_deps failure
376+
"ignore_strict_deps": True,
377+
},
355378
"browser": {
379+
# TODO: Fix strict_deps failure
380+
"ignore_strict_deps": True,
356381
"shards": 10,
357382
"size": "large",
358383
"flaky": True,
@@ -361,9 +386,14 @@ LARGE_SPECS = {
361386
"//:node_modules/@angular/material",
362387
],
363388
},
364-
"prerender": {},
389+
"prerender": {
390+
# TODO: Fix strict_deps failure
391+
"ignore_strict_deps": True,
392+
},
365393
"browser-esbuild": {},
366394
"ssr-dev-server": {
395+
# TODO: Fix strict_deps failure
396+
"ignore_strict_deps": True,
367397
"extra_deps": [
368398
"//packages/angular/ssr/node:node_rjs",
369399
"//:node_modules/@types/browser-sync",
@@ -379,6 +409,7 @@ LARGE_SPECS = {
379409
name = "build_angular_" + spec + "_test_lib",
380410
testonly = True,
381411
srcs = glob(["src/builders/" + spec + "/**/*_spec.ts"]),
412+
ignore_strict_deps = LARGE_SPECS[spec].get("ignore_strict_deps", False),
382413
deps = [
383414
# Dependencies needed to compile and run the specs themselves.
384415
":build_angular_rjs",

‎packages/angular_devkit/schematics/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ ts_project(
3939
name = "schematics_test_lib",
4040
testonly = True,
4141
srcs = glob(["src/**/*_spec.ts"]),
42+
# TODO: Fix strict_deps failure
43+
ignore_strict_deps = True,
4244
deps = [
4345
":node_modules/@angular-devkit/core",
4446
":schematics",

‎packages/angular_devkit/schematics/tasks/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ ts_project(
1818
],
1919
),
2020
data = ["package.json"],
21+
# TODO: Fix strict_deps failure
22+
ignore_strict_deps = True,
2123
module_name = "@angular-devkit/schematics/tasks",
2224
deps = [
2325
"//:node_modules/@types/node",

‎packages/angular_devkit/schematics/testing/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ ts_project(
1414
include = ["**/*.ts"],
1515
),
1616
data = ["package.json"],
17+
# TODO: Fix strict_deps failure
18+
ignore_strict_deps = True,
1719
module_name = "@angular-devkit/schematics/testing",
1820
deps = [
1921
"//:node_modules/rxjs",

‎packages/schematics/angular/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ ts_project(
8181
for (src, _) in ALL_SCHEMA_TARGETS
8282
],
8383
data = RUNTIME_ASSETS,
84+
# TODO: Fix strict_deps failure
85+
ignore_strict_deps = True,
8486
module_name = "@schematics/angular",
8587
deps = [
8688
":node_modules/@angular-devkit/core",

‎tests/angular_devkit/schematics/tools/file-system-engine-host/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ ts_project(
2121
"**/*.js",
2222
],
2323
),
24+
# TODO: Fix strict_deps failure
25+
ignore_strict_deps = True,
2426
deps = [
2527
"//:node_modules/@types/jasmine",
2628
"//:node_modules/@types/node",

0 commit comments

Comments
 (0)