Skip to content

Commit 6c0d33d

Browse files
AmitMYfilipesilva
authored andcommitted
fix(@angular/cli): increase keepAliveTimeout for all Node 8 versions
1 parent 16db656 commit 6c0d33d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/@angular/cli/tasks/serve.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -284,14 +284,14 @@ export default Task.extend({
284284
opn(serverAddress);
285285
}
286286
});
287-
// Node 8.0 - 8.4 has a keepAliveTimeout bug which doesn't respect active connections.
287+
// Node 8 has a keepAliveTimeout bug which doesn't respect active connections.
288288
// Connections will end after ~5 seconds (arbitrary), often not letting the full download
289289
// of large pieces of content, such as a vendor javascript file. This results in browsers
290290
// throwing a "net::ERR_CONTENT_LENGTH_MISMATCH" error.
291291
// https://github.com/angular/angular-cli/issues/7197
292292
// https://github.com/nodejs/node/issues/13391
293293
// https://github.com/nodejs/node/commit/2cb6f2b281eb96a7abe16d58af6ebc9ce23d2e96
294-
if (/^v8.[0-4].\d+$/.test(process.version)) {
294+
if (/^v8.\d.\d+$/.test(process.version)) {
295295
httpServer.keepAliveTimeout = 30000; // 30 seconds
296296
}
297297
})

0 commit comments

Comments
 (0)