-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to add a 3rd party remote dependency? #2903
Comments
I would think for this use case you would want the script directly in the index. Since the script is probably cache controlled by the host domain (Google) you would want the request to always come directly from their server. Ex: Google Analytics. If the code is called directly from your angular app that would be different and you would need to bundle it into the app. |
Facebook recommends this approach:
Maybe |
For remote scripts it's perfectly fine to put whatever in That being, we have talked about allowing for a difference between dev/prod scripts, and them being loaded local/cdn. See #2796 regarding this topic. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Google's guideline for the "Google Sign" recommends this approach:
I read in another issue though that when using an
angular-cli
project nothing should be directly added to theindex.html
, but adding a remote script in theangular-cli.json
doesn't seems to work:I already read the README.md but found nothing on this.
What is the recommended approach for this scenario?
Thank you.
The text was updated successfully, but these errors were encountered: