Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@ngtools/webpack): fix error in compiler CLI when i18nFormat is undefined #6617

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Conversation

rayros
Copy link
Contributor

@rayros rayros commented Jun 8, 2017

TypeError: Cannot read property 'toLowerCase' of undefined
    at Extractor.serialize (/node_modules/@angular/compiler-cli/src/extractor.js:45:32)
    at /node_modules/@angular/compiler-cli/src/extractor.js:32:33
    at process._tickCallback (internal/process/next_tick.js:103:7)

TypeError: Cannot read property 'toLowerCase' of undefined
    at Extractor.serialize (/node_modules/@angular/compiler-cli/src/extractor.js:45:32)
    at /node_modules/@angular/compiler-cli/src/extractor.js:32:33
    at process._tickCallback (internal/process/next_tick.js:103:7)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@rayros
Copy link
Contributor Author

rayros commented Jun 8, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jun 8, 2017
@hansl hansl self-requested a review June 8, 2017 18:22
hansl
hansl previously requested changes Jun 8, 2017
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rayros, could you follow our guidelines for commit messages? This commit should have the following header:

fix(@ngtools/webpack): fix error in compiler CLI when i18nFormat is undefined.

Thank you.

@rayros rayros changed the title fix undefined fix(@ngtools/webpack): fix error in compiler CLI when i18nFormat is undefined Jun 8, 2017
@Brocco Brocco dismissed hansl’s stale review June 19, 2017 19:14

Requested fixes were addressed.

@hansl
Copy link
Contributor

hansl commented Jun 19, 2017

@rayros just a nit; you didn't change the commit message, just the PR title. We'll do it manually but keep that in mind next time. cheers!

@hansl hansl merged commit a0db191 into angular:master Jun 19, 2017
@rayros
Copy link
Contributor Author

rayros commented Jun 19, 2017

Ok, sorry I didn't know that there is a difference between PR title and commit message.

Brocco pushed a commit that referenced this pull request Jun 21, 2017
Brocco pushed a commit that referenced this pull request Jun 21, 2017
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants