-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@ngtools/webpack): fix error in compiler CLI when i18nFormat is undefined #6617
Conversation
rayros
commented
Jun 8, 2017
•
edited
Loading
edited
TypeError: Cannot read property 'toLowerCase' of undefined at Extractor.serialize (/node_modules/@angular/compiler-cli/src/extractor.js:45:32) at /node_modules/@angular/compiler-cli/src/extractor.js:32:33 at process._tickCallback (internal/process/next_tick.js:103:7)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rayros, could you follow our guidelines for commit messages? This commit should have the following header:
fix(@ngtools/webpack): fix error in compiler CLI when i18nFormat is undefined.
Thank you.
@rayros just a nit; you didn't change the commit message, just the PR title. We'll do it manually but keep that in mind next time. cheers! |
Ok, sorry I didn't know that there is a difference between PR title and commit message. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |