test(@ngtools/webpack): add source-map-support. #7191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karma plugin relies on source-map-support being a dependency of karma-source-map-support and npm 3+ flat dependency tree. pnpm/pnpm#863
filipesilva
suggested changes
Jul 28, 2017
| @@ -91,6 +91,7 @@ | |||
| "silent-error": "^1.0.0", | |||
| "source-map": "^0.5.6", | |||
| "source-map-loader": "^0.2.0", | |||
| "source-map-support": "^0.4.1", | |||
There was a problem hiding this comment.
Can you add this to https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/package.json as well?
We have several packages being deployed from the same repo so multiple package.json need to be updated.
There was a problem hiding this comment.
Dependency added and also fixed the enumerate in karma.ts.
|
I agree with the conclusions in pnpm/pnpm#863 and would like to see this merged. |
filipesilva
approved these changes
Jul 31, 2017
|
Done, thanks! |
hansl
pushed a commit
that referenced
this pull request
Aug 3, 2017
karma plugin relies on source-map-support being a dependency of karma-source-map-support and npm 3+ flat dependency tree. pnpm/pnpm#863
hansl
pushed a commit
that referenced
this pull request
Aug 3, 2017
karma plugin relies on source-map-support being a dependency of karma-source-map-support and npm 3+ flat dependency tree. pnpm/pnpm#863
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
…r#7191) karma plugin relies on source-map-support being a dependency of karma-source-map-support and npm 3+ flat dependency tree. pnpm/pnpm#863
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
karma plugin relies on source-map-support being a dependency of karma-source-map-support and npm 3+ flat dependency tree.
pnpm/pnpm#863